Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12546

Horrific performance faux pas in the choice module

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.9
    • 1.9
    • Choice
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

    Description

      It is calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it is calling it with identical parameters each time.

      Actually, since the fix for MDL-12331, the check it is doing with the data is entirely redundant anyway.

      Attachments

        Activity

          People

            timhunt Tim Hunt
            timhunt Tim Hunt
            Dan Marsden Dan Marsden
            Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              3/Mar/08