Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12546

Horrific performance faux pas in the choice module

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Choice
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      It is calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it is calling it with identical parameters each time.

      Actually, since the fix for MDL-12331, the check it is doing with the data is entirely redundant anyway.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Tester:
            Dan Marsden
            Participants:
            Component watchers:
            Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08