Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17458 Install & upgrade 2.0 cleanup META
  3. MDL-12553

Postgresql connection can be simplified in install.php

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Fixed
    • Minor
    • 2.0
    • 1.9
    • Installation
    • None
    • PostgreSQL 8.2, Moodle 1.9.3
    • PostgreSQL
    • MOODLE_19_STABLE
    • MOODLE_20_STABLE

    Description

      There is currently a hack that makes a custom string to pass on to the adodb layer, "aggregating" the username, password, host and dbname, for postgresql. This is not necessary, as the adbodb doc at http://phplens.com/lens/adodb/docs-adodb.htm#connect_ex explicitly states that pgsql 7 & 8 support connecting using the "four arguments".

      This actually corrects a bug, occuring when the connection fails, and the user comes back to the database setup screen, with all fields empty, except for the "host", which contains the aggregated information.

      Along is a patch fixing this.

      As this seems to be historical (August 2004), Martin, can you confirm that it's alright to remove these lines? I tested on pgsql 8.2, but I don't have access to any older version.

      Attachments

        Activity

          People

            skodak Petr Skoda (Inactive)
            scyrma Mathieu Petit-Clair
            Nobody Nobody
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.