Moodle
  1. Moodle
  2. MDL-12697

Category Themes do not appear when editing off

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9, 2.0
    • Component/s: Course, Themes
    • Labels:
      None
    • Environment:
      Mac OSX 10.4.11
      PHP 5.2.4
      MySQL 5.0.45
    • Rank:
      29708

      Description

      Category themes (when enabled) are not applied when editing is turned off. With editing enabled, the theme appears correctly.

      1. cat.diff
        0.7 kB
        Darryl Pogue

        Activity

        Hide
        Darryl Pogue added a comment -

        Diff file attached which appears to fix the issue.

        Nowhere in the file did it actually use the theme name stored in the database and attempt to set that as the displayed theme. The patch applies the theme just before printing the header.

        Show
        Darryl Pogue added a comment - Diff file attached which appears to fix the issue. Nowhere in the file did it actually use the theme name stored in the database and attempt to set that as the displayed theme. The patch applies the theme just before printing the header.
        Hide
        Dan Poltawski added a comment -

        Hi, thanks for the report, this should now be fixed in CVS.

        I took a slightly difference approach to the patch to ensure we only do this when switched on.

        Show
        Dan Poltawski added a comment - Hi, thanks for the report, this should now be fixed in CVS. I took a slightly difference approach to the patch to ensure we only do this when switched on.
        Hide
        Nate Baxley added a comment -

        This is still happening for us on Moodle 1.9.2

        Show
        Nate Baxley added a comment - This is still happening for us on Moodle 1.9.2
        Hide
        Tim Hunt added a comment -

        Well I have just tested in my Moodle 1.9.2 install, and category themes work with editing both on and off. If you can reproduce this problem, please give exact steps to perform to reproduce the problem.

        Show
        Tim Hunt added a comment - Well I have just tested in my Moodle 1.9.2 install, and category themes work with editing both on and off. If you can reproduce this problem, please give exact steps to perform to reproduce the problem.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: