Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12830

Missing errorbox css in formal white theme

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.4, 1.9
    • Fix Version/s: 1.8.5, 1.9.1
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      Moodle standard theme has reddish background-color css declaration in styles_color.css
      .errorbox {
      color:#ffffff;
      border-color:#660000;
      background-color:#990000;
      }

      .errorboxcontent {
      background-color:#FFBBBB;
      }
      Current moodle standard distribution themes: chameleon, cornflower, metal, oceanblue and orangewhite have their own background colors for errorbox.
      However, popular formal_white is missing .errorbox and .errorboxcontent colors.

      Suggested fix for moodle\theme\formal_white\fw_color.css
      add
      .errorbox {
      color:#ffffff;
      border-color:#660000;
      background-color:#990000;
      }

      .errorboxcontent {
      }
      or something to that effect...
      Joseph

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andreabix Andrea Bicciolo added a comment -

            Fixed in 1.7, 1.8, 1.9 and HEAD

            Show
            andreabix Andrea Bicciolo added a comment - Fixed in 1.7, 1.8, 1.9 and HEAD
            Hide
            andreabix Andrea Bicciolo added a comment -

            Closing now. Thanks for the report.

            Show
            andreabix Andrea Bicciolo added a comment - Closing now. Thanks for the report.
            Hide
            rezeau Joseph Rézeau added a comment -

            Andrea,
            I do not understand why the red color is commented out for the error box. This is precisely what I remarked was missing in error messages.
            .errorbox

            { /* color:#ffffff; */ border-color:#990000; background-color:#FEF9F6; }

            should be:
            .errorbox

            { color:#ffffff; border-color:#990000; background-color:#FEF9F6; }

            Joseph

            Show
            rezeau Joseph Rézeau added a comment - Andrea, I do not understand why the red color is commented out for the error box. This is precisely what I remarked was missing in error messages. .errorbox { /* color:#ffffff; */ border-color:#990000; background-color:#FEF9F6; } should be: .errorbox { color:#ffffff; border-color:#990000; background-color:#FEF9F6; } Joseph
            Hide
            andreabix Andrea Bicciolo added a comment -

            Joseph, simply put a white text would be poorly contrasted over the current backgorund. That's all. Let me know If I'm missing something.

            Show
            andreabix Andrea Bicciolo added a comment - Joseph, simply put a white text would be poorly contrasted over the current backgorund. That's all. Let me know If I'm missing something.
            Hide
            rezeau Joseph Rézeau added a comment -

            Oops, you are right! What I want in fact is RED text over white background, inside a red box (similar in fact to the following ERROR or MISSING REQUIRED ERROR formattings in moodle 1.8 and 1.9 mforms:

            form.mform span.error, form.mform span.required {
            color: red;
            }
            form.mform div.error,form.mform fieldset.error {
            border: 1px solid red;
            padding: 5px;
            color: inherit;
            }

            Show
            rezeau Joseph Rézeau added a comment - Oops, you are right! What I want in fact is RED text over white background, inside a red box (similar in fact to the following ERROR or MISSING REQUIRED ERROR formattings in moodle 1.8 and 1.9 mforms: form.mform span.error, form.mform span.required { color: red; } form.mform div.error,form.mform fieldset.error { border: 1px solid red; padding: 5px; color: inherit; }

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Apr/08