Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12930

Need to fix for "Search for webpage ..." input title attribute on resource module.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 1.9, 2.0
    • Component/s: Resource
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      When we mouseover "Search for webpage ..." button on "resource > Link to a file or website", an incorrect title attribute "Choose a local file (CD-ROM)" is popuped.
      We can fix this incorrect popup message by the following modification.

      Index: resource.class.php
      ===================================================================
      RCS file: /cvsroot/moodle/moodle/mod/resource/type/file/resource.class.php,v
      retrieving revision 1.75
      diff -u -r1.75 resource.class.php
      — resource.class.php 14 Dec 2007 21:22:38 -0000 1.75
      +++ resource.class.php 11 Jan 2008 11:30:57 -0000
      @@ -687,7 +687,7 @@

      if (!empty($CFG->resource_websearch)) {
      $searchbutton = $mform->addElement('button', 'searchbutton', get_string('searchweb', 'resource').'...');

      • $buttonattributes = array('title'=>get_string('localfilechoose', 'resource'), 'onclick'=>"return window.open('"
        + $buttonattributes = array('title'=>get_string('searchweb', 'resource'), 'onclick'=>"return window.open('"
        . "$CFG->resource_websearch', 'websearch', 'menubar=1,location=1,directories=1,toolbar=1,"
        . "scrollbars,resizable,width=800,height=600');");
        $searchbutton->updateAttributes($buttonattributes);

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              mits Mitsuhiro Yoshida
              Tester:
              Nicolas Martignoni
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Mar/08