Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12961

Forum: Rating triggers undefined property error - cmidnumber

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      When posting a rating with debugging turned to ALL I received the following PHP notice

      Notice: Undefined property: stdClass::$cmidnumber in /home/arborrow/Moodle/code/19stable/mod/forum/lib.php on line 1168

      This is caused because the forum_grade_item_update function in /mod/forum/lib.php expects the $forum variable to have a field $cmidnumber ( * @param object $forum object with extra cmidnumber). I traced this back to /mod/forum/rate.php and found that the extra cmidnumber field was not being added on prior to passing the variable to the forum_grade_item_update function.

      I'll attach one possible patch that I used to get around this.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              aborrow Anthony Borrow
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Mar/08