Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12985

Admin option "Force default timezone" should read "Force timezone" as it cannot then be changed by the user

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.3, 2.5, 2.5.2
    • Fix Version/s: 2.6
    • Component/s: Administration, Language
    • Labels:

      Description

      You can force everyone in a Moodle to have the same timezone, the setting is labelled as "Force default timezone" which doesn't make sense. You either choose a default, which by definition can later be changed or you force a choice on the user. The latter is the case here so the text shoudl read "Force timezone"

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d;

            4d6f6f646c6521

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; 4d6f6f646c6521
            Hide
            bawjaws David Scotson added a comment -

            Still there in Moodle 2.5 master.

            Show
            bawjaws David Scotson added a comment - Still there in Moodle 2.5 master.
            Hide
            danmarsden Dan Marsden added a comment -

            Just saw this - seemed to make sense and it's such a simple fix - Helen Foster any chance you could peer review/make sure this looks ok?

            Show
            danmarsden Dan Marsden added a comment - Just saw this - seemed to make sense and it's such a simple fix - Helen Foster any chance you could peer review/make sure this looks ok?
            Hide
            tsala Helen Foster added a comment -

            Hi Dan, thanks for asking me to take a look at this.

            I agree that it makes sense and is a simple fix. As it is simply a language string change, the easiest way to deal with it is for me to change it in the en_fix language pack (which is then merged with the en lang pack at regular intervals) rather than having the issue go through the usual process of peer review, integration review and testing. Shall I do this?

            PS I expected to find some info in the dev docs on using the en_fix language pack for language string changes, but unfortunately I drew a blank. Michael de Raadt can you help with this?

            Show
            tsala Helen Foster added a comment - Hi Dan, thanks for asking me to take a look at this. I agree that it makes sense and is a simple fix. As it is simply a language string change, the easiest way to deal with it is for me to change it in the en_fix language pack (which is then merged with the en lang pack at regular intervals) rather than having the issue go through the usual process of peer review, integration review and testing. Shall I do this? PS I expected to find some info in the dev docs on using the en_fix language pack for language string changes, but unfortunately I drew a blank. Michael de Raadt can you help with this?
            Hide
            danmarsden Dan Marsden added a comment -

            cool - first I've heard of en_fix - makes sense thanks Helen - assigning it to you to sort.

            Show
            danmarsden Dan Marsden added a comment - cool - first I've heard of en_fix - makes sense thanks Helen - assigning it to you to sort.
            Hide
            tsala Helen Foster added a comment -

            Thanks Dan, I have changed the string in en_fix, which will be merged with the en lang pack one week before the next release, as mentioned in http://docs.moodle.org/dev/Major_release_process .

            Show
            tsala Helen Foster added a comment - Thanks Dan, I have changed the string in en_fix, which will be merged with the en lang pack one week before the next release, as mentioned in http://docs.moodle.org/dev/Major_release_process .
            Hide
            salvetore Michael de Raadt added a comment -

            There is a mention of using the en_fix language pack here...

            http://docs.moodle.org/25/en/AMOS#Suggesting_improvements_to_English_language_strings

            I have added a note about language string changes here...

            http://docs.moodle.org/dev/Tracker_introduction#Reporting_an_issue

            Show
            salvetore Michael de Raadt added a comment - There is a mention of using the en_fix language pack here... http://docs.moodle.org/25/en/AMOS#Suggesting_improvements_to_English_language_strings I have added a note about language string changes here... http://docs.moodle.org/dev/Tracker_introduction#Reporting_an_issue
            Hide
            tsala Helen Foster added a comment - - edited

            Thanks Michael Hopefully any newly reported language string changes will be picked up when triaging the issue.

            Show
            tsala Helen Foster added a comment - - edited Thanks Michael Hopefully any newly reported language string changes will be picked up when triaging the issue.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13