Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13151

Different language string for phone1 and phone2 entries

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5, 1.6, 1.7, 1.8, 1.9
    • Fix Version/s: 1.9.1
    • Component/s: Language, Other
    • Labels:
      None
    • Affected Branches:
      MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Although they are different entries in the database, phone1 and phone2 both use get_string('phone'). When looking to integrate Moodle with SMS services this makes it difficult to ensure that the user enters the number in the correct field.

      Can strings phone1 and phone2 be introduced? In addition to language strings the following files in Moodle1.9 make reference to get_string('phone'):

      admin\uploaduser_form.php
      $mform->addElement('text', 'phone1', get_string('phone'), 'maxlength="20" size="25"');
      $mform->addElement('text', 'phone2', get_string('phone'), 'maxlength="20" size="25"');

      file\resource.class.php
      'userphone1' => array('langstr' => get_string('phone').' 1',
      'userphone2' => array('langstr' => get_string('phone').' 2',

      repository\resource.class.php
      'userphone1' => array('langstr' => get_string('phone').' 1',
      'userphone2' => array('langstr' => get_string('phone').' 2',

      user\editlib.php
      $mform->addElement('text', 'phone1', get_string('phone'), 'maxlength="20" size="25"');
      $mform->addElement('text', 'phone2', get_string('phone'), 'maxlength="20" size="25"');

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dongsheng Dongsheng Cai
              Reporter:
              jballard James Ballard
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              cameron1729, David Mudrák (@mudrd8mz), Helen Foster, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/08