Moodle
  1. Moodle
  2. MDL-19303 META: XMLDB Editor various bugs/improvements
  3. MDL-13204

XMLDB check_indexes options runs for too long and PHP stops the script.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.4
    • Fix Version/s: 1.8.10, 1.9.6, 2.0
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      Windows 2003, Apache 2.2.4, PHP 5.2.5, Oracle 10g
    • Database:
      Oracle
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      When we try to check the database indexes from Admin->Misc->XMLDB editor->Check Indexes, after we confirm the run, we get a blank page after some time.

      It seems index checking is taking longer than the configured max_execution_time and PHP stops executing the page. We should raise the execution time before calling '$xmldb_action->invoke();' to cater for this. I've tried with 'set_time_limit(0)' and it works ok, but I don't know the code so maybe this is a little bit too much and we could use a lower limit.

      Saludos. Iñaki.

        Gliffy Diagrams

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          I've fixed this for 2.0 because, on it, we are running all the tests with the XMLDBCheckAction base class, so I've implemented time limit extension there.

          Going to backport that to 1.9 individual tests... now.

          Show
          Eloy Lafuente (stronk7) added a comment - I've fixed this for 2.0 because, on it, we are running all the tests with the XMLDBCheckAction base class, so I've implemented time limit extension there. Going to backport that to 1.9 individual tests... now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Done the "extra" time fix has been backported both to 19_STABLE (check indexes and bigints) and 18_STABLE (check indexes).

          Resolving as fixed, agur!

          Show
          Eloy Lafuente (stronk7) added a comment - Done the "extra" time fix has been backported both to 19_STABLE (check indexes and bigints) and 18_STABLE (check indexes). Resolving as fixed, agur!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: