Moodle
  1. Moodle
  2. MDL-13372

Enhance Scales to allow text to be associated with each scale item

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.9
    • Fix Version/s: DEV backlog
    • Component/s: Gradebook
    • Labels:
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      573

      Description

      Currently, when defining a custom scale, the user enters a comma-separate list of items followed by an overall description. This should be changed to allow input of [item,description] pairs followed by an overall description. Use a form for the [item,description] pairs, rather than a comma-separated list.

      There should also be a page where a user can view a custom scale in tabular form. The page should be formatted so that it is acceptable for printing (File -> print).

      Use case: When a scale is used for a rubric, the teacher needs to associate criteria with each scale element.

      The item descriptions in a rubric can be long enough to warrant use of the html editor, but this is not essential.

        Issue Links

          Activity

          John Isner created issue -
          Hide
          Matt Campbell added a comment -

          I would add a help button, available where students can rate items, that would be automatically built from this information.

          Show
          Matt Campbell added a comment - I would add a help button, available where students can rate items, that would be automatically built from this information.
          Hide
          John Isner added a comment -

          See MDL-13371, which contains a parallel discussion on ratings-related Help files in mod/forum. If the enhancement to Scales suggested here is implemented, ratings-related Help files will no longer be needed, since the Scales themselves effectively contain their own "help." A button next to each forum rating dropdown menu would query the Scale for its rubric and display it to the user in a popup, together with the material from the Scale description, which would contain any general advice for using the Scale tor rate forum posts.

          Show
          John Isner added a comment - See MDL-13371 , which contains a parallel discussion on ratings-related Help files in mod/forum. If the enhancement to Scales suggested here is implemented, ratings-related Help files will no longer be needed, since the Scales themselves effectively contain their own "help." A button next to each forum rating dropdown menu would query the Scale for its rubric and display it to the user in a popup, together with the material from the Scale description, which would contain any general advice for using the Scale tor rate forum posts.
          Hide
          Petr Škoda added a comment -

          we can not change the way we store the scales in db, because a lot of code would break
          I agree this feature could be useful

          Show
          Petr Škoda added a comment - we can not change the way we store the scales in db, because a lot of code would break I agree this feature could be useful
          Hide
          John Isner added a comment -

          Is it really possible that code using a relational database can be so closely tied to the database that adding a single column to a table will break "a lot of code?" I thought "data abstraction" was the whole point of using a relational database.

          If what you say is true, then it is a major issue. All of the code that so intimately depends on Scales needs to be refactored so that simple enhancements, like this one, are possible. If this issue is closed with "Won't fix," will start that discussion and create the issue.

          From the number of tracker notifications I have been getting in the last few days, it seems that developers are in a big rush to close as many issues as possible. If so, I hope this one will not be a casualty of the "rush to quality."

          Show
          John Isner added a comment - Is it really possible that code using a relational database can be so closely tied to the database that adding a single column to a table will break "a lot of code?" I thought "data abstraction" was the whole point of using a relational database. If what you say is true, then it is a major issue. All of the code that so intimately depends on Scales needs to be refactored so that simple enhancements, like this one, are possible. If this issue is closed with "Won't fix," will start that discussion and create the issue. From the number of tracker notifications I have been getting in the last few days, it seems that developers are in a big rush to close as many issues as possible. If so, I hope this one will not be a casualty of the "rush to quality."
          Hide
          Petr Škoda added a comment - - edited

          we can not change the db structure in 1.9.x, I thought you want to push it into one field, sorry for the misunderstanding
          if you are concerned about quality then please help test the fixes and look for unknown bugs in 1.9dev

          Show
          Petr Škoda added a comment - - edited we can not change the db structure in 1.9.x, I thought you want to push it into one field, sorry for the misunderstanding if you are concerned about quality then please help test the fixes and look for unknown bugs in 1.9dev
          Hide
          John Isner added a comment -

          I just looked at the database schema for Scale. Now I see that you have just one table, and that the 'scale' attribute is a comma-separated list. Ugh. I assumed there were two tables. I would never suggest packing the description in with the CSL. That would things even worse

          Scale should probably be replaced by two tables, Scale and Scale_item. The item-level description could be stored in the Scale_item table. Is that something that could be done after 1.9? Would this really require so many code changes, or is the CSL parsed by a function that could be reimplemented?

          I find 1.9 beta to be very stable. Most of my concerns are about usability. The current issue was motivated by a discussion about forum ratings. moodle.org forum ratings are being abused, and some of us think the problem can be partly solved by having Scales carry their own information.

          Show
          John Isner added a comment - I just looked at the database schema for Scale. Now I see that you have just one table, and that the 'scale' attribute is a comma-separated list. Ugh. I assumed there were two tables. I would never suggest packing the description in with the CSL. That would things even worse Scale should probably be replaced by two tables, Scale and Scale_item. The item-level description could be stored in the Scale_item table. Is that something that could be done after 1.9? Would this really require so many code changes, or is the CSL parsed by a function that could be reimplemented? I find 1.9 beta to be very stable. Most of my concerns are about usability. The current issue was motivated by a discussion about forum ratings. moodle.org forum ratings are being abused, and some of us think the problem can be partly solved by having Scales carry their own information.
          Hide
          Petr Škoda added a comment -

          I read those forum talks too, I think I am more useful when coding and not taking part in those flamewars
          There are some interface functions for scales in new gradebook, but unfortunately all 1.8 code is accessing the scale table directly.

          I agree we have to work more on usability, bugfixing and docs in 1.9.x.

          Show
          Petr Škoda added a comment - I read those forum talks too, I think I am more useful when coding and not taking part in those flamewars There are some interface functions for scales in new gradebook, but unfortunately all 1.8 code is accessing the scale table directly. I agree we have to work more on usability, bugfixing and docs in 1.9.x.
          Helen Foster made changes -
          Field Original Value New Value
          Link This issue has been marked as being related by MDL-13371 [ MDL-13371 ]
          Hide
          Nicolas Connault added a comment -

          This is a good idea but definitely not for 1.9

          Show
          Nicolas Connault added a comment - This is a good idea but definitely not for 1.9
          Nicolas Connault made changes -
          Fix Version/s 2.0 [ 10122 ]
          Assignee Martin Dougiamas [ dougiamas ] Nicolas Connault [ nicolasconnault ]
          Martin Dougiamas made changes -
          Assignee Nicolas Connault [ nicolasconnault ] moodle.com [ moodle.com ]
          Hide
          Evan Irving-Pease added a comment -

          It strikes me that the reason this can't easily be fixed is the same reason that ticket MDL-17258 hasn't been resolved... the `scale` table needs to be broken into two tables.

          As resolving ticket MDL-17258 is important for a larger project I am currently working on, my employer has asked me to develop a patch for it. However I see no reason not to resolve this ticket at the same time (it shouldn't be much work after the new table is in place).

          I've started a new forum thread (http://moodle.org/mod/forum/discuss.php?d=140907) asking for comments and suggestions about changes people want to see with scales if any of you would like to contribute to that discussion.

          Cheers,
          Evan.

          Show
          Evan Irving-Pease added a comment - It strikes me that the reason this can't easily be fixed is the same reason that ticket MDL-17258 hasn't been resolved... the `scale` table needs to be broken into two tables. As resolving ticket MDL-17258 is important for a larger project I am currently working on, my employer has asked me to develop a patch for it. However I see no reason not to resolve this ticket at the same time (it shouldn't be much work after the new table is in place). I've started a new forum thread ( http://moodle.org/mod/forum/discuss.php?d=140907 ) asking for comments and suggestions about changes people want to see with scales if any of you would like to contribute to that discussion. Cheers, Evan.
          Andrew Davis made changes -
          Link This issue will be resolved by MDL-17258 [ MDL-17258 ]
          Martin Dougiamas made changes -
          Fix Version/s 2.0.1 [ 10420 ]
          Fix Version/s 2.0 [ 10122 ]
          Martin Dougiamas made changes -
          Workflow jira [ 24785 ] MDL Workflow [ 43011 ]
          Martin Dougiamas made changes -
          Fix Version/s 2.0.2 [ 10421 ]
          Fix Version/s 2.0.1 [ 10420 ]
          Hide
          Helen Foster added a comment -

          Assigning to our gradebook guy Andrew for consideration.

          Show
          Helen Foster added a comment - Assigning to our gradebook guy Andrew for consideration.
          Helen Foster made changes -
          Labels triaged
          Assignee moodle.com [ moodle.com ] Andrew Davis [ andyjdavis ]
          Fix Version/s DEV backlog [ 10464 ]
          Fix Version/s 2.0.2 [ 10421 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 43011 ] MDL Full Workflow [ 71419 ]
          Hide
          Andrew Davis added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Andrew Davis added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Andrew Davis made changes -
          Assignee Andrew Davis [ andyjdavis ]

            People

            • Votes:
              7 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: