Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13435

lib/xmlize.php doesn't care about xml errors

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.4, 1.9, 2.0
    • Fix Version/s: 2.0
    • Component/s: Backup
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The library function xmlize does not have any kind of error reporting at all so even quite subtle bugs in the processed xml code silently produce incorrect data. For example the attached file contains an HTML entity and this simply truncates the xml data at the point of the entity returning an ostensibly valid yet incomplete result structure.

      This is bad. It should, were possible, return an error condition.

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            howardsmiller Howard Miller
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10