Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13629

Gradebook: Unexpected behavior in selection of lowest grade to drop and resultant category calculation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9, 1.9.12
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Gradebook
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      log in as admin or teacher.
      delete all gradeable activities (or create a new course)
      create 3 assignments. use "simple direct grading". Set them to have a maximum grade of 5, 10 and 15 respectively.

      You may want to keep the grader report and categories and items "full view" open in 2 tabs.

      Go to the categories and items "full view" screen.
      Click the edit/hand icon for the course grade item.
      Set aggregation to "simple weighted mean of grades".
      Set maximum grade to 100.00
      Go to the grader report and enter a grade of 10 for the assignment out of 10

      On the categories screen, set "drop the lowest" to None.
      Tick "Aggregate only non-empty grades" if it isnt already
      On the grader report, the students course grade should become 100% --> (1.0*10)/10
      1.0 = the student grade, 100%
      the first 10 = the assignment maximum
      the other 10 = the sum of all included activity maximums
      (The student only has a single graded and they got 100% so their course grade is 100%)

      Untick "Aggregate only non-empty grades" for the course
      Reload the grader report.
      Course grade should become 33.33%--> (0.0*5 + 1.0*10 + 0.0*15)/30
      (the other assignments are now included and are counted as 0)

      On the categories screen, set "drop the lowest" to 1.
      Reload the grader report.
      Course grade should become 66.7% (or 66.67 or similar) --> (0.0*5 + 1.0*10)/15
      (the denominator was reduced due to the removal of the assignment out of 15, the most "weighty" assignment)

      Enter a 0 for the assignment out of 15.
      Reload the grader report.
      Course grade should stay at 66.67 --> (0.0*5 + 1.0*10)/15
      (it makes no difference if the assignment grade is 0 or empty)

      Enter a 0 for the assignment out of 5.
      The course grade should stay the same.

      Un-override the assignment out of 15 (it goes back to being empty)
      The course grade should stay the same.

      Un-override the assignment out of 5.
      The course grade should stay the same.

      Un-override the assignment out of 10.
      The course grade should go back to 0.

      Show
      log in as admin or teacher. delete all gradeable activities (or create a new course) create 3 assignments. use "simple direct grading". Set them to have a maximum grade of 5, 10 and 15 respectively. You may want to keep the grader report and categories and items "full view" open in 2 tabs. Go to the categories and items "full view" screen. Click the edit/hand icon for the course grade item. Set aggregation to "simple weighted mean of grades". Set maximum grade to 100.00 Go to the grader report and enter a grade of 10 for the assignment out of 10 On the categories screen, set "drop the lowest" to None. Tick "Aggregate only non-empty grades" if it isnt already On the grader report, the students course grade should become 100% --> (1.0*10)/10 1.0 = the student grade, 100% the first 10 = the assignment maximum the other 10 = the sum of all included activity maximums (The student only has a single graded and they got 100% so their course grade is 100%) Untick "Aggregate only non-empty grades" for the course Reload the grader report. Course grade should become 33.33%--> (0.0*5 + 1.0*10 + 0.0*15)/30 (the other assignments are now included and are counted as 0) On the categories screen, set "drop the lowest" to 1. Reload the grader report. Course grade should become 66.7% (or 66.67 or similar) --> (0.0*5 + 1.0*10)/15 (the denominator was reduced due to the removal of the assignment out of 15, the most "weighty" assignment) Enter a 0 for the assignment out of 15. Reload the grader report. Course grade should stay at 66.67 --> (0.0*5 + 1.0*10)/15 (it makes no difference if the assignment grade is 0 or empty) Enter a 0 for the assignment out of 5. The course grade should stay the same. Un-override the assignment out of 15 (it goes back to being empty) The course grade should stay the same. Un-override the assignment out of 5. The course grade should stay the same. Un-override the assignment out of 10. The course grade should go back to 0.
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-13629_droplow

      Description

      Using simple weighted mean of grade with assignments of varying point values I am not sure what the logic ought to be for selecting the lowest grade. I would assume that it would be the lowest percentage (points earned/points possible) for an assignment and where there are multiple zeros that it would select the one with the highest possible points (i.e. the one that would have the greatest weight).

      I would expect a blank and zero to be treated the same unless the gradebook as been set to ignore blank grades. In my particular case, I did not check the box for the category to Aggregate only non-empty grades. So I believe that an empty grade should be considered equivalent to a zero (at least that is the behavior I am expecting).

      What I noticed was that the category average changed depending on which assignment was blank and which was zero. I would have expected the category value to remain the same. I am attaching the course backup (zip) to facilitate reproduction as well as two screenshots showing the swap between the 0 and blank on the last student with different calculated values for the assignment category.

        Gliffy Diagrams

          Attachments

          1. backup-mdl-12842p-20080223-2158.zip
            37 kB
          2. blankmin.png
            blankmin.png
            132 kB
          3. droplowest_a.png
            droplowest_a.png
            128 kB
          4. droplowest_b.png
            droplowest_b.png
            129 kB
          5. droppingblanks.png
            droppingblanks.png
            129 kB
          6. limits2.patch
            2 kB

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12