Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13860

ADL Scorm 2004 LMS Conformance Test

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.8.5, 1.9.1, 2.0
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      Windows xp sp2, ADL Test Suite Scorm 2004 3rd edition v1.0.2
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      I tried to tried to evaluate moodle 1.9 for Scorm 2004 with the ADL test suite and the lms test packages
      In test package DMI are generated many errors in SCOs 3 and 4
      and in package DMB i cant get to the second SCO of the package
      I have attached the detailed log with the errors
      And searching in moodle forums and in general i dont understand if moodle is Scorm 2004 conformant?

        Gliffy Diagrams

          Activity

          alexgr alextagoulis created issue -
          Hide
          jenntbrooks Jennifer Brooks added a comment -

          Moodle is not yet SCORM 2004 conformant. I have also found that the second SCO in an aggregation will not launch; neither will the 4th if there are 5 SCOs and the 6th if there are 7 SCOs. I am currently fixing this bug. There are other issues that will also need to be fixed before Moodle will be SCORM 2004 conformant.

          Show
          jenntbrooks Jennifer Brooks added a comment - Moodle is not yet SCORM 2004 conformant. I have also found that the second SCO in an aggregation will not launch; neither will the 4th if there are 5 SCOs and the 6th if there are 7 SCOs. I am currently fixing this bug. There are other issues that will also need to be fixed before Moodle will be SCORM 2004 conformant.
          Hide
          jenntbrooks Jennifer Brooks added a comment -

          Clarification: This bug is limited to the use of the "continue" navigation request. That is, it is still possible to launch the SCOs by clicking on them in the TOC when "choice" is enabled.

          Show
          jenntbrooks Jennifer Brooks added a comment - Clarification: This bug is limited to the use of the "continue" navigation request. That is, it is still possible to launch the SCOs by clicking on them in the TOC when "choice" is enabled.
          Hide
          jenntbrooks Jennifer Brooks added a comment -

          Ana Cláudia (in MDL-13887) reported:
          When I use version 5.2.5 of the PHP, to sail in the Scorm for the buttons prev/next, the pages jumps of 2 in 2 pages, or either has access for example page 1, later the 3 and the 5. E when I install version 5.2.0 of the PHP, the navigation function perfectly.

          Show
          jenntbrooks Jennifer Brooks added a comment - Ana Cláudia (in MDL-13887 ) reported: When I use version 5.2.5 of the PHP, to sail in the Scorm for the buttons prev/next, the pages jumps of 2 in 2 pages, or either has access for example page 1, later the 3 and the 5. E when I install version 5.2.0 of the PHP, the navigation function perfectly.
          Hide
          danmarsden Dan Marsden added a comment -

          Hi jennifer - that's related to MDL-13093 - Petr put a fix together that seems to fix it - I'm waiting to hear from Kimberly Prewitt to make sure it works before I commit the patch to 1.9stable/HEAD

          Dan

          Show
          danmarsden Dan Marsden added a comment - Hi jennifer - that's related to MDL-13093 - Petr put a fix together that seems to fix it - I'm waiting to hear from Kimberly Prewitt to make sure it works before I commit the patch to 1.9stable/HEAD Dan
          Hide
          jenntbrooks Jennifer Brooks added a comment -

          Funny, I fixed it using code very similar to Kristof's. If Kimberly is still having trouble with Petr's patch, we can try adding the following lines in SCORM_13lib.php:

          $nextsco = current($scoes);
          if($nextsco->id == $sco->id)

          { $nextsco = next($scoes); }

          This should replace the one line: $nextsco = next($scoes);

          Although very similar, I think it's different enough from Kristof's fix to possibly work for Kimberly.

          Show
          jenntbrooks Jennifer Brooks added a comment - Funny, I fixed it using code very similar to Kristof's. If Kimberly is still having trouble with Petr's patch, we can try adding the following lines in SCORM_13lib.php: $nextsco = current($scoes); if($nextsco->id == $sco->id) { $nextsco = next($scoes); } This should replace the one line: $nextsco = next($scoes); Although very similar, I think it's different enough from Kristof's fix to possibly work for Kimberly.
          Hide
          danmarsden Dan Marsden added a comment -

          hah! - classic! - welcome to the scorm module!

          haven't tested your fix yet, but personally I like Petr's fix better as it fixes the bad logic used in the foreach, whereas yours potentially "work's around" the bad logic...

          fyi that foreach logic appears in lib.php, scorm12lib.php, scorm13lib.php and the aicc lib. (which petr's patch fixes)

          Dan

          Show
          danmarsden Dan Marsden added a comment - hah! - classic! - welcome to the scorm module! haven't tested your fix yet, but personally I like Petr's fix better as it fixes the bad logic used in the foreach, whereas yours potentially "work's around" the bad logic... fyi that foreach logic appears in lib.php, scorm12lib.php, scorm13lib.php and the aicc lib. (which petr's patch fixes) Dan
          Hide
          mchurch Mike Churchward added a comment -

          I just committed a change to 'datamodle.php' that corrected a mistyped function call. In our tests, this was causing navigation errors. Fixing the function call has fixed our navigation issues.

          Show
          mchurch Mike Churchward added a comment - I just committed a change to 'datamodle.php' that corrected a mistyped function call. In our tests, this was causing navigation errors. Fixing the function call has fixed our navigation issues.
          mchurch Mike Churchward made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.0 [ 10122 ]
          Fix Version/s 1.9.1 [ 10240 ]
          Fix Version/s 1.8.5 [ 10252 ]
          Resolution Fixed [ 1 ]
          Hide
          skodak Petr Skoda added a comment -

          thanks

          Show
          skodak Petr Skoda added a comment - thanks
          skodak Petr Skoda made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          QA Assignee skodak
          Assignee Jennifer Brooks [ jenntbrooks ] Mike Churchward [ mchurch ]
          Hide
          skodak Petr Skoda added a comment -

          Hello Mike, please tag your commits as merged next time

          Show
          skodak Petr Skoda added a comment - Hello Mike, please tag your commits as merged next time
          dougiamas Martin Dougiamas made changes -
          Workflow jira [ 25359 ] MDL Workflow [ 59119 ]
          dougiamas Martin Dougiamas made changes -
          Workflow MDL Workflow [ 59119 ] MDL Full Workflow [ 88267 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Apr/08