Moodle
  1. Moodle
  2. MDL-13922

Essay question grade input would be better as a dropdown.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.9
    • Fix Version/s: None
    • Component/s: Questions, Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      4218

      Description

      I have found that its a bit of a pain having to type the grade in all the time. It also appears that a quiz made of essay questions has 0 in the gradebook when actually it hasn't been graded yet. It would be good to have a distinction between ungraded and deliberately graded as 0.

        Activity

        Matt Gibson created issue -
        Matt Gibson made changes -
        Field Original Value New Value
        Summary Essay question grade input dropdown would be better as a dropdown. Essay question grade input would be better as a dropdown.
        Hide
        Tim Hunt added a comment -

        I'm not convinced - but I am not dismissing the idea either.

        This is probably not difficult to implement if anyone wants to have a go at it. You probably just need to edit /question/comment.html to change the <input type="text" ... to a <select ...

        Show
        Tim Hunt added a comment - I'm not convinced - but I am not dismissing the idea either. This is probably not difficult to implement if anyone wants to have a go at it. You probably just need to edit /question/comment.html to change the <input type="text" ... to a <select ...
        Tim Hunt made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Matt Gibson added a comment -

        Well my original reason was that I mark using the (my) AJAX marking block, which will soon find its way to the modules and plugins database. I click on the students name from the front page and get the single-question grading pop-up, but if they have written nothing, or gibberish (not that uncommon with some of them), to give them 0, I can't just press save, as there will be no change to the database and it will still appear as unmarked. My thinking was that a dropdown which started with 'ungraded' would be a better option as then it would differentiate between 'ungraded' and 'deliberate zero' and necessitate a db write.

        On the other hand, I may have just been inelegant with my admittedly amateur SQL. Is there any db change that I have missed if I submit the question without altering the grade or comments?

        Show
        Matt Gibson added a comment - Well my original reason was that I mark using the (my) AJAX marking block, which will soon find its way to the modules and plugins database. I click on the students name from the front page and get the single-question grading pop-up, but if they have written nothing, or gibberish (not that uncommon with some of them), to give them 0, I can't just press save, as there will be no change to the database and it will still appear as unmarked. My thinking was that a dropdown which started with 'ungraded' would be a better option as then it would differentiate between 'ungraded' and 'deliberate zero' and necessitate a db write. On the other hand, I may have just been inelegant with my admittedly amateur SQL. Is there any db change that I have missed if I submit the question without altering the grade or comments?
        Hide
        Tim Hunt added a comment -

        One difficulty is to decide which options should be in the drop-down. That would have to be based on the question max grade, and the number of decimal places set in the quiz. But if you do the naive thing there, then in some situations you would have thousands of options.

        To answer your question of a long time ago: The logic for whether a set of inputs counts as actually assigning a manual grade is in question_process_comment in lib/questionlib.php. I'll leave it to you to read the code. Then, the correct way to detect if a state is already graded is just a check on $state->event, which you can do in pure SQL - have a look at mod/quiz/report/grading in HEAD (not on the 1.9 stable branch.)

        Show
        Tim Hunt added a comment - One difficulty is to decide which options should be in the drop-down. That would have to be based on the question max grade, and the number of decimal places set in the quiz. But if you do the naive thing there, then in some situations you would have thousands of options. To answer your question of a long time ago: The logic for whether a set of inputs counts as actually assigning a manual grade is in question_process_comment in lib/questionlib.php. I'll leave it to you to read the code. Then, the correct way to detect if a state is already graded is just a check on $state->event, which you can do in pure SQL - have a look at mod/quiz/report/grading in HEAD (not on the 1.9 stable branch.)
        Hide
        Tim Hunt added a comment -

        I guess that what you could do is look at the max grade for the question, and the number of decimal places used, and if the number of possibilities is < 100, use a dropdown, otherwise use a text box.

        Show
        Tim Hunt added a comment - I guess that what you could do is look at the max grade for the question, and the number of decimal places used, and if the number of possibilities is < 100, use a dropdown, otherwise use a text box.
        Hide
        Matt Gibson added a comment -

        I see what you mean, but in reality, how often would someone give a question 3.7 points? It would be more sensible to give it 37 and then scale the grade to a max of 10 in the quiz setup. I could see giving increments of 0.5, but if the assignment code works without half percents, then maybe the quiz code will be ok too? I think that overall, the convenience of a dropdown is more useful than the convenience of being able to manually specify 3.7 on the odd occasions when it's needed, simply on the basis that the dropdown is useful every time, whereas the manual decimal point are only useful sometimes (rarely?) and can be worked around easily with a one off action during quiz setup.

        What do you reckon?

        Show
        Matt Gibson added a comment - I see what you mean, but in reality, how often would someone give a question 3.7 points? It would be more sensible to give it 37 and then scale the grade to a max of 10 in the quiz setup. I could see giving increments of 0.5, but if the assignment code works without half percents, then maybe the quiz code will be ok too? I think that overall, the convenience of a dropdown is more useful than the convenience of being able to manually specify 3.7 on the odd occasions when it's needed, simply on the basis that the dropdown is useful every time, whereas the manual decimal point are only useful sometimes (rarely?) and can be worked around easily with a one off action during quiz setup. What do you reckon?
        Martin Dougiamas made changes -
        Workflow jira [ 25426 ] MDL Workflow [ 43162 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 43162 ] MDL Full Workflow [ 71563 ]
        Hide
        Tim Hunt added a comment -

        This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

        For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        Tim Hunt added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
        Tim Hunt made changes -
        Assignee Tim Hunt [ timhunt ]

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: