Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13952

"enrol_ldap_autocreate" create courses, even if "enrol_ldap_autocreate" is set to "no"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.4
    • Fix Version/s: 1.8.11, 1.9.7, 2.0
    • Component/s: Course
    • Labels:
      None
    • Environment:
      Debian Linux 4.0, PHP Version 4.4.4-8, Apache 1.3.34
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      "enrol_ldap_autocreate" create courses, even if "enrol_ldap_autocreate" is set to "no"

      so i have done the following changes on enrol/ldap/enrol.php:
      from:
      if (!is_object($course_obj){
      // ok, now then let's create it! print "Creating Course $idnumber...";

      to:
      if (!is_object($course_obj) && $CFG->enrol_ldap_autocreate) {
      // ok, now then let's create it! print "Creating Course $idnumber...";

      it's this right? is this a bug?

      Regards
      Bruno

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              brunoz Bruno Zuber created issue -
              Hide
              bluenovember Clinton Graham added a comment -

              I agree. This is an obvious bug with a clear fix.

              Show
              bluenovember Clinton Graham added a comment - I agree. This is an obvious bug with a clear fix.
              bluenovember Clinton Graham made changes -
              Field Original Value New Value
              Link This issue is duplicated by MDL-18989 [ MDL-18989 ]
              Hide
              iarenaza Iñaki Arenaza added a comment -

              This should be fixed in CVS for 1.8, 1.9 and HEAD.

              Thanks a lot Bruno and Clinton for the heads up

              Saludos,
              Iñaki.

              Show
              iarenaza Iñaki Arenaza added a comment - This should be fixed in CVS for 1.8, 1.9 and HEAD. Thanks a lot Bruno and Clinton for the heads up Saludos, Iñaki.
              iarenaza Iñaki Arenaza made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.8.11 [ 10383 ]
              Fix Version/s 1.9.7 [ 10360 ]
              Fix Version/s 2.0 [ 10122 ]
              Resolution Fixed [ 1 ]
              iarenaza Iñaki Arenaza made changes -
              Link This issue will help resolve MDL-18989 [ MDL-18989 ]
              dougiamas Martin Dougiamas made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              dougiamas Martin Dougiamas made changes -
              Workflow jira [ 25460 ] MDL Workflow [ 59221 ]
              dougiamas Martin Dougiamas made changes -
              Workflow MDL Workflow [ 59221 ] MDL Full Workflow [ 88332 ]

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Nov/09