Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13983

in a html quick if a radio button is disabled you get '( )' or '(x)' rather than just disabling the button

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: Accessibility
    • Labels:
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      as per http://tracker.moodle.org/browse/MDL-8627 but with radio buttons

      patch copied/modified from lib/form/advcheckbox.php should be applied to lib/form/radio.php

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              quen Sam Marshall added a comment -

              Petr asked for this to be assigned to him so he can check it

              Show
              quen Sam Marshall added a comment - Petr asked for this to be assigned to him so he can check it
              Hide
              skodak Petr Skoda added a comment -

              going to ask MD tomorrow, my +0.9 for this

              Show
              skodak Petr Skoda added a comment - going to ask MD tomorrow, my +0.9 for this
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              +0.1 here too (the idea, haven't reviewed the patch)

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - +0.1 here too (the idea, haven't reviewed the patch)
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Pinging Mr. MD....

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Pinging Mr. MD....
              Hide
              timhunt Tim Hunt added a comment -

              This fix still seems to be good, and is now available as https://github.com/timhunt/moodle/commit/81994df4af82a24444aaac5afd4be3bd14684e78. Shall I do a pull request?

              Show
              timhunt Tim Hunt added a comment - This fix still seems to be good, and is now available as https://github.com/timhunt/moodle/commit/81994df4af82a24444aaac5afd4be3bd14684e78 . Shall I do a pull request?
              Hide
              timhunt Tim Hunt added a comment -

              Note that the corresponding change was made for checkboxes years ago, so I think it makes a lot of sense to do this for radio buttons to. This is code we have been using at the OU for ages.

              For testing, you need to find a form with radio buttons that get frozen, and there does not seem to be one in the standard Moodle code (I searched for ->freeze). I suspect this only came up in an ou-specific plugin.

              I you really want to test, create a test script with a form with a frozen radio button.

              I think this is a worthwhile accessibility fix, so the pull request should be accepted, even though this bit of the API is not currently used.

              Show
              timhunt Tim Hunt added a comment - Note that the corresponding change was made for checkboxes years ago, so I think it makes a lot of sense to do this for radio buttons to. This is code we have been using at the OU for ages. For testing, you need to find a form with radio buttons that get frozen, and there does not seem to be one in the standard Moodle code (I searched for ->freeze). I suspect this only came up in an ou-specific plugin. I you really want to test, create a test script with a form with a frozen radio button. I think this is a worthwhile accessibility fix, so the pull request should be accepted, even though this bit of the API is not currently used.
              Hide
              tsala Helen Foster added a comment -

              Thanks again Tim.

              Show
              tsala Helen Foster added a comment - Thanks again Tim.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/May/11