Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-13985

in function element_to_popup_window, button name should NOT consist of more than one word

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.1
    • Component/s: Accessibility
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Description
      ---------------
      In file weblib.php

      In previous moodle versions, we had : function link_to_popup_window ($url, $name='popup', $linkname='click here', etc.
      In 1.9 and 2.0 we now have:
      function element_to_popup_window ($type=null, $url=null, $name=null, $linkname=null, etc.
      and further down in that function, we have:
      // get some default string, using the localized version of legacy defaults
      if (!$name)

      { $name = get_string('popupwindow'); }
      Unfortunately, that string consists of several words, currently in English = $string['popupwindowname'] = 'Popup window';
      When a BUTTON is used for a link to a popup window, and that button has a name parameters consisting of more than one word, it crashes MS Internet Explorer (it's OK in FireFox).
      This is most annoying for me because I use pop up windows in the Questionnaire module. Please fix ASAP.
      ----
      FIX
      ----
      replace
      function element_to_popup_window ($type=null, $url=null, $name=null, $linkname=null,
      with
      function element_to_popup_window ($type=null, $url=null, $name='popup', $linkname=null,etc.
      and
      remove:
      if (!$name) { $name = get_string('popupwindow'); }

      ------------------
      Joseph

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/08