Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26697 mediaplugin fixes and improvements META
  3. MDL-14002

Multimedia filter should be able to create embeds that don't include a download link

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0.3
    • Component/s: Filters
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The multimedia filter always includes the original link (that was turned into an embed), so for example you have:

      (link to video)

      (video player)

      Sometimes the video format isn't appropriate for download (.flv) or for another reason you don't want to include the actual link, so that it is just:

      (video player)

      and the original link vanishes.

      Our users are currently doing this by making the <a href="whatever"></a> i.e. a blank a tag. This works but you end up with a blank a tag in the code, which is not very good.

      I propose changing it so that if you do this (make the contents of the <a> blank so the link doesn't show up) it automatically doesn't include the link at all, replacing it entirely with the media player.

      As a bonus when I do this I'll fix the regular expression which are currently slightly broken [Not in a way that would cause any actual issue at present but they would with this change.]

      So... is this wanted? for 1.9x or for 2.0? Please let me know and if so I'll produce a patch.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11