Moodle
  1. Moodle
  2. MDL-14054

CLONE -Cloze format not displaying the correct answers

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.9.4, 2.0
    • Component/s: Quiz
    • Labels:
      None
    • Environment:
      Linux
    • Database:
      MySQL
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      26452

      Description

      Cloze format is not displaying correct answers when that option is chosen in the quiz.

      1. cloze-correctionanswer-patches.tgz
        1 kB
        Matt Oquist
      2. cloze-correctionanswer-patches.tgz
        1 kB
        Matt Oquist
      1. coorect.jpg
        16 kB
      2. correctandfeedback.jpg
        17 kB
      3. screenshot-1.jpg
        129 kB

        Issue Links

          Activity

          Hide
          Matt Oquist added a comment - - edited

          Definitely still an issue in $release = '1.9 + (Build: 20080325)', and I stumbled upon the problem in our production server, which is $release = '1.8.3 +'. Students were submitting answers that looked right, but they were missing essential punctuation or something, and the teachers couldn't tell why Moodle was marking the answer wrong.

          I have a patch that takes care of it, at least for shortanswer-type Cloze questions. I'll attach the patch in a few minutes.

          I'm not really worried about this problem for any question types other than shortanswer, since that's all we're using in production. But the patch will also take care of NUMERICAL (though I haven't tested that, it's the same case). Multiple choice doesn't need it so much, because the teacher can probably figure out what Moodle was expecting even if it isn't specified.

          Show
          Matt Oquist added a comment - - edited Definitely still an issue in $release = '1.9 + (Build: 20080325)', and I stumbled upon the problem in our production server, which is $release = '1.8.3 +'. Students were submitting answers that looked right, but they were missing essential punctuation or something, and the teachers couldn't tell why Moodle was marking the answer wrong. I have a patch that takes care of it, at least for shortanswer-type Cloze questions. I'll attach the patch in a few minutes. I'm not really worried about this problem for any question types other than shortanswer, since that's all we're using in production. But the patch will also take care of NUMERICAL (though I haven't tested that, it's the same case). Multiple choice doesn't need it so much, because the teacher can probably figure out what Moodle was expecting even if it isn't specified.
          Hide
          Matt Oquist added a comment -

          This tarball includes patches for 1.6.6, 1.7.4, 1.8.4, and 1.9 build 20080325.

          I've tested in 1.8.4 and 1.9, and the patches look correct for 1.6.6 and 1.7.4 on a casual visual inspection.

          Show
          Matt Oquist added a comment - This tarball includes patches for 1.6.6, 1.7.4, 1.8.4, and 1.9 build 20080325. I've tested in 1.8.4 and 1.9, and the patches look correct for 1.6.6 and 1.7.4 on a casual visual inspection.
          Hide
          Matt Oquist added a comment - - edited

          Forgot to include the issue key last time; these patches note MDL-14054.

          edit: It just occurred to me that I should've used cvs to produce these patches. I dunno why I didn't...anyhoo, the patches are for question/type/multianswer/questiontype.php, which is not obvious by looking at them.

          Show
          Matt Oquist added a comment - - edited Forgot to include the issue key last time; these patches note MDL-14054 . edit: It just occurred to me that I should've used cvs to produce these patches. I dunno why I didn't...anyhoo, the patches are for question/type/multianswer/questiontype.php, which is not obvious by looking at them.
          Hide
          Pierre Pichet added a comment -

          I will work on this as this should be synchronized with MDL-13419 which is already CVS to HEAD and 19_STABLE.

          Show
          Pierre Pichet added a comment - I will work on this as this should be synchronized with MDL-13419 which is already CVS to HEAD and 19_STABLE.
          Hide
          Pierre Pichet added a comment -

          Comparison of the proposed dispaly with mulchoice and match question types

          Show
          Pierre Pichet added a comment - Comparison of the proposed dispaly with mulchoice and match question types
          Hide
          Pierre Pichet added a comment -

          the proposed patch use
          echo "<em><small>$correctanswers_str</small></em>";
          to display. I think the styles options should be used and I will study this further unless somebody have a proposal.
          Should we dispaly the selcect element like the the match question type even if in this case there is no correct answer available.
          The in-line restriction for Cloze proscrib the multiple choice radio button style that allows correct answers display.

          give your comments

          Show
          Pierre Pichet added a comment - the proposed patch use echo "<em><small>$correctanswers_str</small></em>"; to display. I think the styles options should be used and I will study this further unless somebody have a proposal. Should we dispaly the selcect element like the the match question type even if in this case there is no correct answer available. The in-line restriction for Cloze proscrib the multiple choice radio button style that allows correct answers display. give your comments
          Hide
          Matt Oquist added a comment -

          You're right to worry about these styles being hard-coded. I did that just to visually distinguish the correct answer text from the surrounding question text. Perhaps this isn't even necessary, but in any case I'd hate to see this fix held up by a styles issue. I'd rather see the patch applied without the "<em>" and "<small>" tags, and styles applied later after we come up with an acceptable way to do it.

          Show
          Matt Oquist added a comment - You're right to worry about these styles being hard-coded. I did that just to visually distinguish the correct answer text from the surrounding question text. Perhaps this isn't even necessary, but in any case I'd hate to see this fix held up by a styles issue. I'd rather see the patch applied without the "<em>" and "<small>" tags, and styles applied later after we come up with an acceptable way to do it.
          Hide
          Pierre Pichet added a comment -

          As this is not a major bug but a useful feature, I prefer to do it correctly.
          MDL-7494 also address the Cloze question display.
          In the mean time users can apply locally your patch or put the correct answer in the feedback field...

          Show
          Pierre Pichet added a comment - As this is not a major bug but a useful feature, I prefer to do it correctly. MDL-7494 also address the Cloze question display. In the mean time users can apply locally your patch or put the correct answer in the feedback field...
          Hide
          Pierre Pichet added a comment -

          Use the popup to show the correct answer.
          Here an example with feedback.

          Show
          Pierre Pichet added a comment - Use the popup to show the correct answer. Here an example with feedback.
          Hide
          Pierre Pichet added a comment -

          Here an example with only correct answer.

          Show
          Pierre Pichet added a comment - Here an example with only correct answer.
          Hide
          Pierre Pichet added a comment -

          Using the popup does not disturb the actual display.
          I am planning to offer some display options to cloze question.see MDL-14763.
          Need to complete tests before CVS.

          Show
          Pierre Pichet added a comment - Using the popup does not disturb the actual display. I am planning to offer some display options to cloze question.see MDL-14763 . Need to complete tests before CVS.
          Hide
          Pierre Pichet added a comment -

          Was fixed as MDL-14763 is fixed and closed

          Show
          Pierre Pichet added a comment - Was fixed as MDL-14763 is fixed and closed

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: