Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.2
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Various forum related problem to be fixed in 1.9.1

        Gliffy Diagrams

        1. forum_meta_dbg1.patch
          0.8 kB
          Petr Skoda
        2. forum_tracking27.patch
          119 kB
          Petr Skoda
        1. forum_tracking_options.png
          8 kB

          Issue Links

          1.
          Forum Tracking - Logic and Links are wrong Sub-task Closed Petr Skoda
           
          2.
          Improve forum tracking related code in cron Sub-task Closed Petr Skoda
           
          3.
          Improve perf of forum tracking when viewing discussions/forums/index/course page Sub-task Closed Petr Skoda
           
          4.
          Two Daily Digests Sub-task Closed Petr Skoda
           
          5.
          Unread Posts numbers does not always appear correctly on the course page Sub-task Closed Petr Skoda
           
          6.
          Read posts are marked unred Sub-task Closed Petr Skoda
           
          7.
          Advanced search in full report of recent activity displays users from all separated groups Sub-task Closed Petr Skoda
           
          8.
          EVERYONE gets forums posts Sub-task Closed Petr Skoda
           
          9.
          Link to forums in forums list does not work for forums set as separate groups Sub-task Closed Petr Skoda
           
          10.
          Users no longer enrolled in course still receive emails from fourms Sub-task Closed Petr Skoda
           
          11.
          The link "Subscribe to all forums" subscribe in foruns where "Subscriptions not allowed" Sub-task Closed Petr Skoda
           
          12.
          User Profile Forum Report does not show ratings Sub-task Closed Petr Skoda
           
          13.
          Separate groups and forums Sub-task Closed Petr Skoda
           
          14.
          when moving discussions update forumid in forum_read Sub-task Closed Petr Skoda
           
          15.
          broken debug message indicating missing mod files Sub-task Closed Petr Skoda
           
          16.
          switch to system locale/lang when printing processingdigest msg in cron Sub-task Closed Petr Skoda
           
          17.
          adv forum search accessibility Sub-task Closed Petr Skoda
           
          18.
          Wrong group handle in the forum Sub-task Closed Petr Skoda
           
          19.
          improve forum group mode docs/help Sub-task Closed Helen Foster
           
          20.
          When replying to a forum post, all other replies are always marked as unread Sub-task Closed Petr Skoda
           

            Activity

            Hide
            skodak Petr Skoda added a comment -

            sending a patch for review/testing

            Show
            skodak Petr Skoda added a comment - sending a patch for review/testing
            Hide
            skodak Petr Skoda added a comment -

            8., 14. are not fixed yet in patch and there might be some fixes not mentioned above

            Show
            skodak Petr Skoda added a comment - 8., 14. are not fixed yet in patch and there might be some fixes not mentioned above
            Hide
            poltawski Dan Poltawski added a comment -

            Have tried to review code. Looks good.

            Found one minor thing in forum_get_tracking_link() you are using the wrong strings for linktext, I think it should be:

            if (forum_tp_is_tracked($forum))

            { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; }

            else

            { $linktitle = $strtrackforum; $linktext = $strtrackforum; }
            Show
            poltawski Dan Poltawski added a comment - Have tried to review code. Looks good. Found one minor thing in forum_get_tracking_link() you are using the wrong strings for linktext, I think it should be: if (forum_tp_is_tracked($forum)) { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; } else { $linktitle = $strtrackforum; $linktext = $strtrackforum; }
            Hide
            poltawski Dan Poltawski added a comment -

            Hmm, found an issue with front page site news.

            Before patch: Most recent site news post displayed
            After patch: All site news posts displayed

            Show
            poltawski Dan Poltawski added a comment - Hmm, found an issue with front page site news. Before patch: Most recent site news post displayed After patch: All site news posts displayed
            Hide
            skodak Petr Skoda added a comment -

            Could you be please more specific about the frontpage problem? What should I look for exactly?

            Show
            skodak Petr Skoda added a comment - Could you be please more specific about the frontpage problem? What should I look for exactly?
            Hide
            poltawski Dan Poltawski added a comment -

            Sorry, in the front page settings:

            Front page items when logged in is set to 'News items' (as the only option)
            News items to show is set to 1

            Now on the front page 1 news item is displayed. When I switch to the new patch, all the news items are displayed.

            Show
            poltawski Dan Poltawski added a comment - Sorry, in the front page settings: Front page items when logged in is set to 'News items' (as the only option) News items to show is set to 1 Now on the front page 1 news item is displayed. When I switch to the new patch, all the news items are displayed.
            Hide
            skodak Petr Skoda added a comment -

            thanks, testing new patch

            Show
            skodak Petr Skoda added a comment - thanks, testing new patch
            Hide
            skodak Petr Skoda added a comment -

            the new count on course page should be fixed now

            Show
            skodak Petr Skoda added a comment - the new count on course page should be fixed now
            Hide
            skodak Petr Skoda added a comment -

            Dan, the following code was not cahnged by the patch, not sure what is correct:
            if (forum_tp_is_tracked($forum))

            { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; }

            else

            { $linktitle = $strtrackforum; $linktext = $strtrackforum; }

            Show
            skodak Petr Skoda added a comment - Dan, the following code was not cahnged by the patch, not sure what is correct: if (forum_tp_is_tracked($forum)) { $linktitle = $strnotrackforum; $linktext = $strnotrackforum; } else { $linktitle = $strtrackforum; $linktext = $strtrackforum; }
            Hide
            smithrn Ryan Smith added a comment -

            I just updated from CVS on MOODLE_19_STABLE on my test site and now I can't get to any forums. After updating I visited moodle/admin and it did prompt to update the forum activity. When I try to visit a forum page, such as:

            ../moodle/mod/forum/index.php?id=920

            I get a white screen, no output. The following errors are in my Apache error.log:

            [Mon Apr 14 00:58:18 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib
            dmllib.php on line 2160, referer: /moodle/course/view.php?id=920

            [Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Warning: Illegal offset type in isset or empty in C:\\Apache2\\htdocs\\moodle\\lib
            accesslib.php on line 2561, referer: /moodle/course/view.php?id=920

            [Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib
            dmllib.php on line 2160, referer: /moodle/course/view.php?id=920

            Show
            smithrn Ryan Smith added a comment - I just updated from CVS on MOODLE_19_STABLE on my test site and now I can't get to any forums. After updating I visited moodle/admin and it did prompt to update the forum activity. When I try to visit a forum page, such as: ../moodle/mod/forum/index.php?id=920 I get a white screen, no output. The following errors are in my Apache error.log: [Mon Apr 14 00:58:18 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib dmllib.php on line 2160, referer: /moodle/course/view.php?id=920 [Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Warning: Illegal offset type in isset or empty in C:\\Apache2\\htdocs\\moodle\\lib accesslib.php on line 2561, referer: /moodle/course/view.php?id=920 [Mon Apr 14 00:58:20 2008] [error] [client 137.112.60.250] PHP Catchable fatal error: Object of class object could not be converted to string in C:\\Apache2\\htdocs\\moodle\\lib dmllib.php on line 2160, referer: /moodle/course/view.php?id=920
            Hide
            skodak Petr Skoda added a comment -

            Hi Ryan,

            thanks for the report! Could you please apply the patch, it should show the backtrace of the problem, I can not reproduce it myself.

            Show
            skodak Petr Skoda added a comment - Hi Ryan, thanks for the report! Could you please apply the patch, it should show the backtrace of the problem, I can not reproduce it myself.
            Hide
            skodak Petr Skoda added a comment -

            sending patched file too...

            Show
            skodak Petr Skoda added a comment - sending patched file too...
            Hide
            skodak Petr Skoda added a comment -

            BTW Ryan, do you have any PHP accelerator installed?

            Show
            skodak Petr Skoda added a comment - BTW Ryan, do you have any PHP accelerator installed?
            Hide
            skodak Petr Skoda added a comment -

            Ryan, the regression is fixed, please test latest cvs

            Show
            skodak Petr Skoda added a comment - Ryan, the regression is fixed, please test latest cvs
            Hide
            poltawski Dan Poltawski added a comment -

            Attaching screenshot of the forum tracking screen which I hope explains the issue lang strings problem further

            The tooltip has the correct text, the link text is incorrect.

            Show
            poltawski Dan Poltawski added a comment - Attaching screenshot of the forum tracking screen which I hope explains the issue lang strings problem further The tooltip has the correct text, the link text is incorrect.
            Hide
            poltawski Dan Poltawski added a comment -

            That is of course of the forum list of posts screen.

            Show
            poltawski Dan Poltawski added a comment - That is of course of the forum list of posts screen.
            Hide
            skodak Petr Skoda added a comment - - edited

            the like text shows current status and the tool tip says what will happen if you click - I did not invent this, we will have to ask MD

            Show
            skodak Petr Skoda added a comment - - edited the like text shows current status and the tool tip says what will happen if you click - I did not invent this, we will have to ask MD
            Hide
            smithrn Ryan Smith added a comment -

            I am using eAccelerator.

            I just did a CVS update and got the following new files
            mod/forum/lib.php
            mod/forum/search.php
            mod/forum/view.php

            I can now access the forums again.

            Thanks for fixing it quickly!

            Show
            smithrn Ryan Smith added a comment - I am using eAccelerator. I just did a CVS update and got the following new files mod/forum/lib.php mod/forum/search.php mod/forum/view.php I can now access the forums again. Thanks for fixing it quickly!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            Offtopic comment:

            Agreeing 100% about this sort of META bugs (with nice atomic subtasks grouped nicely), it's really a pain to check/understand/verify/close any of those subtasks if all them are committed together.

            So I would suggest to perform also atomic commits, each one fixing one subtask (or at least, the minimum number of subtask possible if strongly connected).

            That way everything will be easier (but for the developer, I know).

            Just one personal proposal... to have everything really atomized and understandable. Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited Offtopic comment: Agreeing 100% about this sort of META bugs (with nice atomic subtasks grouped nicely), it's really a pain to check/understand/verify/close any of those subtasks if all them are committed together. So I would suggest to perform also atomic commits, each one fixing one subtask (or at least, the minimum number of subtask possible if strongly connected). That way everything will be easier (but for the developer, I know). Just one personal proposal... to have everything really atomized and understandable. Ciao
            Hide
            skodak Petr Skoda added a comment -

            Sorry Eloy, I prefer atomic commits too, this one went through several rounds of refactoring and I worked on this for 3 weeks

            Show
            skodak Petr Skoda added a comment - Sorry Eloy, I prefer atomic commits too, this one went through several rounds of refactoring and I worked on this for 3 weeks
            Hide
            poltawski Dan Poltawski added a comment -

            Think i've found a regression in forum_user_outline()

            forum_count_user_posts() is returning an array of objects:

            Array
            (
            [0] => stdClass Object
            (
            [lastpost] =>
            [postcount] => 0
            )

            )

            And forum_user_outline() is assuming just an objet is returned. Visible in activity outline report

            Show
            poltawski Dan Poltawski added a comment - Think i've found a regression in forum_user_outline() forum_count_user_posts() is returning an array of objects: Array ( [0] => stdClass Object ( [lastpost] => [postcount] => 0 ) ) And forum_user_outline() is assuming just an objet is returned. Visible in activity outline report
            Hide
            skodak Petr Skoda added a comment -

            thanks Dan, should be fixed

            Show
            skodak Petr Skoda added a comment - thanks Dan, should be fixed
            Hide
            skodak Petr Skoda added a comment -

            closing, thanks everybody

            Show
            skodak Petr Skoda added a comment - closing, thanks everybody

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/08