Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14150

Split edit tag and manage tag capabilities better

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.1
    • Component/s: Tags
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      We had a complaint from our QA people that the "edit tag" link was only available from tags on your user profile, not for other sorts of tags. This is more visible because we've got the course tagging installed already.

      I've given my users the tag:edit capability but not the tag: manage capability, and the code displaying the link does this:

      (has_capability('moodle/tag:edit', $systemcontext) && (tag_record_tagged_with('user', $USER->id, $tag_object->name) || has_capability('moodle/tag:manage', $systemcontext))

      What I think we need really is a better split between what edit and manage capabilities control. To me it seems reasonable to allow a different set of users in to update the description and related stuff for a tag than you want to give access to the full management interface. Why should a user be able to edit a tag just because they've tagged themselves with it (as opposed to their blog post, or a course).

      (PS I know there's another bug in here about improving the management interface, but I thought this probably deserved a separate issue - feel free to merge, or subtask if you think its best!!)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    15/May/08