Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14152

detect and fix all syntax $a-> and other problems in all language packs and make sure it never happens again

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.1
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      some translators insert spaces after $a-> something
      some translators translate $a->
      some translators make syntax errors

      1/ make script that detects these problems
      2/ fix everything in cvs
      3/ fix lang edit UI to prevent these problems

      These problems often lead to famous blank screens if php 5.2 used because it throws fatal exception because object can not be cast to string anymore.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment - - edited

              packs not fixed:
              ta, ta_lk, mi_wwow, to

              maintainers will have to do that

              we should disable these on moodle.org and inform ppl

              Show
              skodak Petr Skoda added a comment - - edited packs not fixed: ta, ta_lk, mi_wwow, to maintainers will have to do that we should disable these on moodle.org and inform ppl
              Hide
              skodak Petr Skoda added a comment -

              adding some more watchers

              Show
              skodak Petr Skoda added a comment - adding some more watchers
              Hide
              skodak Petr Skoda added a comment - - edited

              sending new version with trailing/leading whitespace detection - fixed some of the lang files but several are really weird, needs more work tomorrow...

              Show
              skodak Petr Skoda added a comment - - edited sending new version with trailing/leading whitespace detection - fixed some of the lang files but several are really weird, needs more work tomorrow...
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Adding one patch in order to check UTF-8 correctness of strings.

              Ciao

              P.S.: I think we should provide this info:

              • In the lang editor, perhaps preventing changes
              • In a wiki page, updated weekly or so, for manual editors.
              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Adding one patch in order to check UTF-8 correctness of strings. Ciao P.S.: I think we should provide this info: In the lang editor, perhaps preventing changes In a wiki page, updated weekly or so, for manual editors.
              Hide
              skodak Petr Skoda added a comment - - edited

              sending latest cvs/lang patch - whitespace fixed too

              Show
              skodak Petr Skoda added a comment - - edited sending latest cvs/lang patch - whitespace fixed too
              Hide
              skodak Petr Skoda added a comment -

              sending latest script with integrated encoding verification by Eloy, thanks

              Show
              skodak Petr Skoda added a comment - sending latest script with integrated encoding verification by Eloy, thanks
              Hide
              skodak Petr Skoda added a comment -

              Assigning to Koen,

              we need to notify maintainers of following lang packs: ta, ta_lk, mi_wwow, to
              and inform them that there are problems in those language packs, the attached script should help them to identify the problems.

              Also we should disable those languages on moodle.org until they are fixed, I guess we need a new policy that broken langs will be disabled on moodle.org until they get fixed to prevent problems like broken cron, blank screens, broken file serving

              Please notify me when they know it - we do not want any political/personal problems on moodle.org

              Show
              skodak Petr Skoda added a comment - Assigning to Koen, we need to notify maintainers of following lang packs: ta, ta_lk, mi_wwow, to and inform them that there are problems in those language packs, the attached script should help them to identify the problems. Also we should disable those languages on moodle.org until they are fixed, I guess we need a new policy that broken langs will be disabled on moodle.org until they get fixed to prevent problems like broken cron, blank screens, broken file serving Please notify me when they know it - we do not want any political/personal problems on moodle.org
              Hide
              koen Koen Roggemans added a comment -

              notified translators

              Show
              koen Koen Roggemans added a comment - notified translators
              Hide
              koen Koen Roggemans added a comment -

              ta: fixed
              ta_lk: fixed
              to: no response at all
              mi_wwow: pending

              Show
              koen Koen Roggemans added a comment - ta: fixed ta_lk: fixed to: no response at all mi_wwow: pending
              Hide
              koen Koen Roggemans added a comment -

              to: email address of translator doesn't exist - user unknown. That explains why they don't respond. I'll do it myself

              Show
              koen Koen Roggemans added a comment - to: email address of translator doesn't exist - user unknown. That explains why they don't respond. I'll do it myself
              Hide
              koen Koen Roggemans added a comment -

              Found a good guy to fix tongan ...
              I keep on emailing translators with problems - each time I check, there is something. Looking forward to a succesfull end of the google summer of code

              Show
              koen Koen Roggemans added a comment - Found a good guy to fix tongan ... I keep on emailing translators with problems - each time I check, there is something. Looking forward to a succesfull end of the google summer of code
              Hide
              skodak Petr Skoda added a comment -

              all fixed

              Show
              skodak Petr Skoda added a comment - all fixed
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Petr, Koen. Could some of you become QA for this bug, verify everything is fine and finally close it? You are really in touch with all the things to check. TIA!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Petr, Koen. Could some of you become QA for this bug, verify everything is fine and finally close it? You are really in touch with all the things to check. TIA!
              Hide
              koen Koen Roggemans added a comment -

              Petr, thanks for fixing. I'll stop Troy, who's working on a fix for Tongan

              Eloy, this we can close the bug, but this is an ongoing thing. Almost every time I update my /lang folder, there are problems. I choose the slow approach by notifying the translators about the errors, explaining what is wrong and how to avoid it.

              At this very moment, everything is clean again, so I'll close the bug. I'll keep on looking at it. Need to do that anyway for all new files that are send by email to me.

              Show
              koen Koen Roggemans added a comment - Petr, thanks for fixing. I'll stop Troy, who's working on a fix for Tongan Eloy, this we can close the bug, but this is an ongoing thing. Almost every time I update my /lang folder, there are problems. I choose the slow approach by notifying the translators about the errors, explaining what is wrong and how to avoid it. At this very moment, everything is clean again, so I'll close the bug. I'll keep on looking at it. Need to do that anyway for all new files that are send by email to me.
              Hide
              koen Koen Roggemans added a comment -

              This needs ongoing following up, which I will do each time I check in new language files

              Show
              koen Koen Roggemans added a comment - This needs ongoing following up, which I will do each time I check in new language files
              Hide
              dougiamas Martin Dougiamas added a comment -

              Can we set up some sort of daily check using the new script which could email a report to Koen when bugs are found?

              Show
              dougiamas Martin Dougiamas added a comment - Can we set up some sort of daily check using the new script which could email a report to Koen when bugs are found?
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Yup, just send me the script and I'll install it wherever you want (download, cvs...) together with the deleted strings one I've running in my servers.

              If you can add a MDLSITE bug for this... that would be peeerfect! Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Yup, just send me the script and I'll install it wherever you want (download, cvs...) together with the deleted strings one I've running in my servers. If you can add a MDLSITE bug for this... that would be peeerfect! Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    15/May/08