Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14238

Filter out submitted only, or ungraded only items on assignment grading table

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0
    • Component/s: Assignment (2.2), Usability
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      There are two sort of items, that needs grading in assignment:

      • files, that uploaded first time;
      • corrected answers, uploaded after teachers grading and comments ( date of the student answer later that date of teacher's grading).

      While first are very easy to find in large table, second requires full attention to every row. It would be much better for teacher, if such rows would be highlighted in some way. It's easy to implement, but saves many trouble for users.

      Also, it will be useful to have check box 'show only answered students' in quick grade mode, because empty strings simply clatter the output (execpt off-site answer assignments, of course).

        Gliffy Diagrams

        1. 20091119_MDL_14238.patch
          9 kB
          Rossiani Wijaya
        2. 20091215_mdl_14238.patch
          10 kB
          Rossiani Wijaya
        3. 20100104_MDL_14238.patch
          11 kB
          Rossiani Wijaya
        4. 20100224_MDL-14238_HEAD.patch
          13 kB
          Rossiani Wijaya
        5. 20100805_MDL-14238_2.0.patch
          16 kB
          Rossiani Wijaya
        6. 20100819_MDL_14238.patch
          18 kB
          Rossiani Wijaya
        7. assignment_filter.html
          0.2 kB
          dmitri dubinin
        8. assignment.highlith.patch
          8 kB
          Oleg Sychev

          Issue Links

            Activity

            Hide
            dquattri Dale William Quattrin added a comment -

            I think this highlighting would be helpful. In addition, I think that there should some assignment tally column in the Assignment List Page that would show the number of graded assignments. This would allow the teacher to quickly compare submissions with graded assignments so that later submissions are recognized and can be graded.

            Show
            dquattri Dale William Quattrin added a comment - I think this highlighting would be helpful. In addition, I think that there should some assignment tally column in the Assignment List Page that would show the number of graded assignments. This would allow the teacher to quickly compare submissions with graded assignments so that later submissions are recognized and can be graded.
            Hide
            chuang Wen Hao Chuang added a comment -

            Could this be implemented in 2.0 maybe? Thanks!

            Show
            chuang Wen Hao Chuang added a comment - Could this be implemented in 2.0 maybe? Thanks!
            Hide
            oa_sychev Oleg Sychev added a comment -

            I could implement it even in 1.9, given that someone from Moodleteam will be so kind to review and apply the developed patch (I'll already have some experience in the area). It's quite easy.

            The only part where I'm need an advice from someone experienced whis Moodle is what style can be used to highlight some strings in the table? I'm developer, not designer. I'd avoid adding a style as there will be need to ajust all themes to this.

            Show
            oa_sychev Oleg Sychev added a comment - I could implement it even in 1.9, given that someone from Moodleteam will be so kind to review and apply the developed patch (I'll already have some experience in the area). It's quite easy. The only part where I'm need an advice from someone experienced whis Moodle is what style can be used to highlight some strings in the table? I'm developer, not designer. I'd avoid adding a style as there will be need to ajust all themes to this.
            Hide
            oa_sychev Oleg Sychev added a comment -

            Well, color highlighting seems problematical considering adding a new style to the themes (thought I will do it if this is what all whants), but now I consider using a different option: dropdown "show all/with submissions only/with ungraded submissions only', and user preference associated with it. Can anyone there review and upply patch?

            Show
            oa_sychev Oleg Sychev added a comment - Well, color highlighting seems problematical considering adding a new style to the themes (thought I will do it if this is what all whants), but now I consider using a different option: dropdown "show all/with submissions only/with ungraded submissions only', and user preference associated with it. Can anyone there review and upply patch?
            Hide
            dougiamas Martin Dougiamas added a comment -

            Reviewing this ...

            Show
            dougiamas Martin Dougiamas added a comment - Reviewing this ...
            Hide
            dougiamas Martin Dougiamas added a comment -

            Um, where is the patch? :-D

            Show
            dougiamas Martin Dougiamas added a comment - Um, where is the patch? :-D
            Hide
            oa_sychev Oleg Sychev added a comment -

            Here it is. I'm just giving it one more testing session to be sure.
            Patch for MDL-15356 is also available.

            Show
            oa_sychev Oleg Sychev added a comment - Here it is. I'm just giving it one more testing session to be sure. Patch for MDL-15356 is also available.
            Hide
            oa_sychev Oleg Sychev added a comment -

            Can anyone here review the patch?

            Show
            oa_sychev Oleg Sychev added a comment - Can anyone here review the patch?
            Hide
            chuang Wen Hao Chuang added a comment -

            OK I could take a look at this next Monday (Dec 22) Pacific time..
            Thanks!

            Show
            chuang Wen Hao Chuang added a comment - OK I could take a look at this next Monday (Dec 22) Pacific time.. Thanks!
            Hide
            oa_sychev Oleg Sychev added a comment -

            This patch worked on our university site about a month, and no one expereince any problem (but many quite like it, as it really makes assginment grading more usable). Please review/apply it.

            Show
            oa_sychev Oleg Sychev added a comment - This patch worked on our university site about a month, and no one expereince any problem (but many quite like it, as it really makes assginment grading more usable). Please review/apply it.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Oleg,

            I had reviewed your patch and work fine on my 1.9.6 version. However I've made some little adjustment on positioning the preference element.

            Also, I found a bug on clicking on the column header, it highlighted the previous column. The patch for this bug is also included within the 20091119_MDL_14238.patch

            Thanks
            Rosie

            Show
            rwijaya Rossiani Wijaya added a comment - Oleg, I had reviewed your patch and work fine on my 1.9.6 version. However I've made some little adjustment on positioning the preference element. Also, I found a bug on clicking on the column header, it highlighted the previous column. The patch for this bug is also included within the 20091119_MDL_14238.patch Thanks Rosie
            Hide
            oa_sychev Oleg Sychev added a comment -

            Thank you for improvments, Rosie. I'm not that much of designer, more a developer.

            I hope that the patch could be applied now and will be useful for the people who voted for it.

            Show
            oa_sychev Oleg Sychev added a comment - Thank you for improvments, Rosie. I'm not that much of designer, more a developer. I hope that the patch could be applied now and will be useful for the people who voted for it.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Found some bugs with hilighting the column.
            I created new patch for the fixed (the only file that effected is grader/lib.php).

            Show
            rwijaya Rossiani Wijaya added a comment - Found some bugs with hilighting the column. I created new patch for the fixed (the only file that effected is grader/lib.php).
            Hide
            rwijaya Rossiani Wijaya added a comment -

            fixed earlier patch, so it has moodle coding convention.
            There's no changes on the functionality.

            Show
            rwijaya Rossiani Wijaya added a comment - fixed earlier patch, so it has moodle coding convention. There's no changes on the functionality.
            Hide
            dougiamas Martin Dougiamas added a comment -

            +1 for HEAD, after a few small fixes to make it part of the pref form.

            Show
            dougiamas Martin Dougiamas added a comment - +1 for HEAD, after a few small fixes to make it part of the pref form.
            Hide
            oa_sychev Oleg Sychev added a comment -

            I'm glad that after an year there is some progress on this issue.

            Martin, could you please look (or assign someone who will look) on the two other small assignment improvment patches from our university too: MDL-17613 and MDL-15356?.

            Show
            oa_sychev Oleg Sychev added a comment - I'm glad that after an year there is some progress on this issue. Martin, could you please look (or assign someone who will look) on the two other small assignment improvment patches from our university too: MDL-17613 and MDL-15356 ?.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            fixed minor changes and add help buttons to option preferences.

            I'm adding Helen to the watcher list.

            Helen, could you take a look the string content for the help buttons? thanks.

            attaching new patch.

            Show
            rwijaya Rossiani Wijaya added a comment - fixed minor changes and add help buttons to option preferences. I'm adding Helen to the watcher list. Helen, could you take a look the string content for the help buttons? thanks. attaching new patch.
            Hide
            tsala Helen Foster added a comment -

            Hi Rosie,

            I'm wondering whether a help button is necessary for the 3 options ('All', 'Submitted' and 'Require grading')? They seem quite obvious to me!

            I think the sentence "Selected preference is saved and will apply to all assignments in all courses." (which I notice the current help files pagesize.html and quickgrade.html also have) is confusing because it doesn't apply to ALL courses (only courses in which a user has appropriate permissions). I suggest it is omitted completely from the help files and just mentioned in the documentation. Similarly I would suggest that there is no need for a new help file savepreferences.html.

            Show
            tsala Helen Foster added a comment - Hi Rosie, I'm wondering whether a help button is necessary for the 3 options ('All', 'Submitted' and 'Require grading')? They seem quite obvious to me! I think the sentence "Selected preference is saved and will apply to all assignments in all courses." (which I notice the current help files pagesize.html and quickgrade.html also have) is confusing because it doesn't apply to ALL courses (only courses in which a user has appropriate permissions). I suggest it is omitted completely from the help files and just mentioned in the documentation. Similarly I would suggest that there is no need for a new help file savepreferences.html.
            Hide
            oa_sychev Oleg Sychev added a comment -

            Is this patch going to be included in Moodle 2.0 at least?

            Show
            oa_sychev Oleg Sychev added a comment - Is this patch going to be included in Moodle 2.0 at least?
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Sam,

            When you have a chance, could you take a look the latest patch? I updated the patch to work with the latest version of 2.0.

            Thanks
            Rosie

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Sam, When you have a chance, could you take a look the latest patch? I updated the patch to work with the latest version of 2.0. Thanks Rosie
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Rosie,

            Thanks for making those changes we discussed yesterday.

            I was just looking at the patch again now and everything looks good except for one remaining thing.

            • mod/assignment/lib.php ln:1238
              The second argument for $table->pagesize should be the total number of records, however you are giving it the total number of records on this page only.
              I see originally it was count($users) which of course can no longer be used as it doesn't take into account the filter.
              My initial thought is that you will need to write some SQL that merges the get_enrolled_users sql and the filter and use that instead, but I'll leave it up to you to investigate what the best option is.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Rosie, Thanks for making those changes we discussed yesterday. I was just looking at the patch again now and everything looks good except for one remaining thing. mod/assignment/lib.php ln:1238 The second argument for $table->pagesize should be the total number of records, however you are giving it the total number of records on this page only. I see originally it was count($users) which of course can no longer be used as it doesn't take into account the filter. My initial thought is that you will need to write some SQL that merges the get_enrolled_users sql and the filter and use that instead, but I'll leave it up to you to investigate what the best option is. Cheers Sam
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Rosie,

            Thanks for the patch, could you please make the following changes:

            • The defines in display_submissions are a no-no, you could either make them class constants or move them to the top of lib.php. Currently there is a chance that they will also conflict with existing defines in situations and they should be renamed. If you make them class constants I'd suggest prefixing them with FILTER_, if you move them to the top of lib.php they should be prefixed with ASSIGNMENT_FILTER_.
            • There are some whitespace issues in lib.php

            The rest looks good, once you have made the above changes feel free to commit the patch.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Rosie, Thanks for the patch, could you please make the following changes: The defines in display_submissions are a no-no, you could either make them class constants or move them to the top of lib.php. Currently there is a chance that they will also conflict with existing defines in situations and they should be renamed. If you make them class constants I'd suggest prefixing them with FILTER_, if you move them to the top of lib.php they should be prefixed with ASSIGNMENT_FILTER_. There are some whitespace issues in lib.php The rest looks good, once you have made the above changes feel free to commit the patch. Cheers Sam
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks Sam for the review.

            Commit Patch to 2.0.

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks Sam for the review. Commit Patch to 2.0.

              People

              • Votes:
                10 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10