Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14402

remove roles button in myMoodle blocks

    XMLWordPrintable

    Details

    • Sprint:
      FRONTEND Sprint 15

      Description

      The block code currently shows the roles button for all non-pinned blocks, including those on the myMoodle page. But on myMoodle, you can't give any-one else permission to see the page or block instance, so I think roles are redundant. The icon is likely to confuse students who wouldn't normally see it.

      I think the fix is in blocks/moodleblock.class.php

      $onmymoodle = strpos( $_SERVER['PHP_SELF'], '/my/index.php' ) !== false ? true : false;
      if( !$onmymoodle & empty($this->instance->pinned)) {

      instead of just if( empty($this->instance->pinned)) {

      Unless you can find a more elegant solution?

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51702 Cannot assign roles to blocks in indexsys.php (default Dashboard or My page)

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48322 Missing capability check when adding assign roles link to block administration

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48380 Remove Assign Roles button from blocks when no roles can be assigned

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              jenny-gray Jenny Gray
              Peer reviewer:
              Zachary Durber
              Integrator:
              Sam Hemelryk
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15