Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14424

Icon for database activity entries requiring approval needs to be made more visible

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.1
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      The icon for database activity entries requiring approval was previously a big red tick. It's now a tiny black tick. Please could it be changed back.

        Gliffy Diagrams

          Activity

          tsala Helen Foster created issue -
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Well, the icon is everything but small:

          http://cvs.moodle.org/moodle/pix/i/approve.gif?view=markup

          was added (because was missing) as part of MDL-8188.

          I guess it's more a thing of CSS or so (the size) ?

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Well, the icon is everything but small: http://cvs.moodle.org/moodle/pix/i/approve.gif?view=markup was added (because was missing) as part of MDL-8188 . I guess it's more a thing of CSS or so (the size) ? Ciao
          Hide
          awyatt A. T. Wyatt added a comment -

          No, actually I think the color is the important thing. As long as we cannot sort by recent changes, that color is very important. It is the only way we can find database entries that have been edited. If the check is black it is extremely hard to distinguish.

          Show
          awyatt A. T. Wyatt added a comment - No, actually I think the color is the important thing. As long as we cannot sort by recent changes, that color is very important. It is the only way we can find database entries that have been edited. If the check is black it is extremely hard to distinguish.
          Hide
          skodak Petr Skoda added a comment -

          icon is now bigger and you can sort by Approved
          I hope the red is not important anymore

          please test and reopen if needed, thanks for the report!

          Show
          skodak Petr Skoda added a comment - icon is now bigger and you can sort by Approved I hope the red is not important anymore please test and reopen if needed, thanks for the report!
          skodak Petr Skoda made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.9.1 [ 10240 ]
          Resolution Fixed [ 1 ]
          Hide
          tsala Helen Foster added a comment -

          Thanks Petr I'll test this on Tuesday.

          Show
          tsala Helen Foster added a comment - Thanks Petr I'll test this on Tuesday.
          tsala Helen Foster made changes -
          QA Assignee tsala
          Hide
          skodak Petr Skoda added a comment -

          reopening, going to make the icon bigger

          Show
          skodak Petr Skoda added a comment - reopening, going to make the icon bigger
          skodak Petr Skoda made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          skodak Petr Skoda added a comment -

          fixed in cvs - approve icon now bigger by default - size can be changed through CSS

          Show
          skodak Petr Skoda added a comment - fixed in cvs - approve icon now bigger by default - size can be changed through CSS
          skodak Petr Skoda made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          tsala Helen Foster added a comment -

          Thanks Petr, the icon looks really good now

          Show
          tsala Helen Foster added a comment - Thanks Petr, the icon looks really good now
          tsala Helen Foster made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          awyatt A. T. Wyatt added a comment -

          Agree! I couldn't miss it! The size made up for not having red. And that was a terrific help. Thanks.

          Show
          awyatt A. T. Wyatt added a comment - Agree! I couldn't miss it! The size made up for not having red. And that was a terrific help. Thanks.
          dougiamas Martin Dougiamas made changes -
          Workflow jira [ 26006 ] MDL Workflow [ 59513 ]
          dougiamas Martin Dougiamas made changes -
          Workflow MDL Workflow [ 59513 ] MDL Full Workflow [ 88665 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/08