Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14451

delete old obsoleted code from HEAD

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      • PHP 5 only
      • upgrade path only from 1.9.x
      • remove some unused legacy functions

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            Yes, I'm happy to move all those four modules to contrib AS LONG AS we keep the tables in the database and are able to recover all the activities later if necessary (eg when you install the module from contrib it keeps using the same tables or runs an upgrade script).

            Hopefully this does spark some renewed interest in those modules.

            Show
            dougiamas Martin Dougiamas added a comment - Yes, I'm happy to move all those four modules to contrib AS LONG AS we keep the tables in the database and are able to recover all the activities later if necessary (eg when you install the module from contrib it keeps using the same tables or runs an upgrade script). Hopefully this does spark some renewed interest in those modules.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            uhm... everything looks quite ok. Just some comments to make you doubt:

            1) The idea of leaving all those "orphan" tables in DB.... with phantom activities and so on.... are we sure it's 100% safe.
            2) Killing all peer-review activities... doesn't sound ok for me, couldn't we try some assignment-subtype or an alternate module... uhm...

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - uhm... everything looks quite ok. Just some comments to make you doubt: 1) The idea of leaving all those "orphan" tables in DB.... with phantom activities and so on.... are we sure it's 100% safe. 2) Killing all peer-review activities... doesn't sound ok for me, couldn't we try some assignment-subtype or an alternate module... uhm... Ciao
            Hide
            skodak Petr Skoda added a comment -

            hi,

            1) it should work - in fact I was running my test sites with missing mods for several months already, I think the 2.0 is a good place to make sure it works as expected, at least we will have more reports
            2) I do not like it either, I hope this will motivate somebody to finally do something about this. well the assignment mod needs rewrite itself, I hope we stop adding stuff there and finally fix it

            Show
            skodak Petr Skoda added a comment - hi, 1) it should work - in fact I was running my test sites with missing mods for several months already, I think the 2.0 is a good place to make sure it works as expected, at least we will have more reports 2) I do not like it either, I hope this will motivate somebody to finally do something about this. well the assignment mod needs rewrite itself, I hope we stop adding stuff there and finally fix it
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Ah, you've done! Did we need to be so radical? grrrr

            :-P

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Ah, you've done! Did we need to be so radical? grrrr :-P
            Hide
            skodak Petr Skoda added a comment -

            It is easy to put it back if somebody steps up and updates the code :-P

            Show
            skodak Petr Skoda added a comment - It is easy to put it back if somebody steps up and updates the code :-P
            Hide
            dougiamas Martin Dougiamas added a comment -
            Show
            dougiamas Martin Dougiamas added a comment - more info here: http://moodle.org/mod/forum/discuss.php?d=96334
            Hide
            skodak Petr Skoda added a comment -

            done, yay!

            Show
            skodak Petr Skoda added a comment - done, yay!

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10