Moodle
  1. Moodle
  2. MDL-14461

Network Servers link causes error if not logged in (rather than asking you to log in)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.1, 2.0
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      31006

      Description

      If you link to a Moodle site via Moodle Networking and you are not logged in to the home moodle you get a nasty error. Everywhere else in Moodle the principle seems to be to ask you to log in and then go to the resource you asked for.

      This is useful, in circumstances where you have copied the link into some resource other than the Network Servers block.

        Activity

        Hide
        Howard Miller added a comment -

        In fact all that's missing is require_login() from auth/mnet/jump.php.

        Show
        Howard Miller added a comment - In fact all that's missing is require_login() from auth/mnet/jump.php.
        Hide
        Howard Miller added a comment -

        I'm going to add Petr as he always spots my stupid mistakes. Can you see why this might be a problem... I've tested simply adding the require_login() and it seems to work as expected, but it seems too easy. Sanity check before I commit?

        Show
        Howard Miller added a comment - I'm going to add Petr as he always spots my stupid mistakes. Can you see why this might be a problem... I've tested simply adding the require_login() and it seems to work as expected, but it seems too easy. Sanity check before I commit?
        Hide
        Howard Miller added a comment -

        The only exception I could think of is if you gave guests permission to jump to a remote site. However, giving them that permission seems to make no difference - they still can't do it, so it has to be a logged in user.

        Show
        Howard Miller added a comment - The only exception I could think of is if you gave guests permission to jump to a remote site. However, giving them that permission seems to make no difference - they still can't do it, so it has to be a logged in user.
        Hide
        Howard Miller added a comment -

        Added require_login() to auth/mnet/jump.php.

        Show
        Howard Miller added a comment - Added require_login() to auth/mnet/jump.php.
        Hide
        Petr Škoda added a comment -

        I think it is ok, closing - thanks

        Show
        Petr Škoda added a comment - I think it is ok, closing - thanks

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: