Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.5, 1.9
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      1. Make disable tabs look more disabled, in particular, make sure they don't do anything when you mouse over them.

      2. Put the active tab into bold, to make it look more active.

      I plan to only commit this to HEAD, to avoid the risk of breaking people's themes.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            OK done. I hope this is uncontroversial. It seemed over the top to post a patch and ask for comments before committing.

            Show
            timhunt Tim Hunt added a comment - OK done. I hope this is uncontroversial. It seemed over the top to post a patch and ask for comments before committing.
            Hide
            daniss Daniele Cordella added a comment -

            Really nice and good idea Tim.
            Thank you.
            Daniele

            Show
            daniss Daniele Cordella added a comment - Really nice and good idea Tim. Thank you. Daniele
            Hide
            pilpi Olli Savolainen added a comment - - edited

            Indeed, this change was one for the better, and I hate to be a pain in our bunghole but: I still think the subtabs need work to a similar direction.

            That is, it is not quite clear visually that there are subtabs in the first place. They do not have the visual appearance of tabs. This becomes problematic in otherwise busy UI's, such as the new Quiz UI (MDL-17284). While the eye scans the page I suspect it is easy to dismiss the grey gradient strip below the primary tab bar as just a visual element.

            I propose a solution such as that in wordpress: have contrasting colors in the second row of tabs, i.e. as the first row of tabs has dark text on a light background, make the second row of tabs have bright-colored text on a dark background.

            See http://moodle.org/mod/forum/discuss.php?d=72828#p326202 for an example.

            The thing that makes this issue even worse is that the default theme does this halfway already: That is, the second row indeed is quite dark already, but the text is also dark, making the text harder to notice, even more so in busy UI's.

            The minimal help to this issue would be to at least highlight the active tab by removing the dark color behind that active element, as demonstrated by the wordpress example.

            Show
            pilpi Olli Savolainen added a comment - - edited Indeed, this change was one for the better, and I hate to be a pain in our bunghole but: I still think the subtabs need work to a similar direction. That is, it is not quite clear visually that there are subtabs in the first place. They do not have the visual appearance of tabs. This becomes problematic in otherwise busy UI's, such as the new Quiz UI ( MDL-17284 ). While the eye scans the page I suspect it is easy to dismiss the grey gradient strip below the primary tab bar as just a visual element. I propose a solution such as that in wordpress: have contrasting colors in the second row of tabs, i.e. as the first row of tabs has dark text on a light background, make the second row of tabs have bright-colored text on a dark background. See http://moodle.org/mod/forum/discuss.php?d=72828#p326202 for an example. The thing that makes this issue even worse is that the default theme does this halfway already: That is, the second row indeed is quite dark already, but the text is also dark, making the text harder to notice, even more so in busy UI's. The minimal help to this issue would be to at least highlight the active tab by removing the dark color behind that active element, as demonstrated by the wordpress example.
            Hide
            timhunt Tim Hunt added a comment -

            Since this issue is about one set of changes that improve tabs in some ways, and since those are done and were finished some time ago, I think it is better to open a separate bugs for further changes of a different type: MDL-17384. (Especially as I don't have time to do any further work on this myself right now.)

            Show
            timhunt Tim Hunt added a comment - Since this issue is about one set of changes that improve tabs in some ways, and since those are done and were finished some time ago, I think it is better to open a separate bugs for further changes of a different type: MDL-17384 . (Especially as I don't have time to do any further work on this myself right now.)
            Hide
            pilpi Olli Savolainen added a comment -

            With hebrew, a separator seems to show even under the active first-level tab, see:

            http://moodle.org/mod/forum/discuss.php?d=111241#p488246

            Show
            pilpi Olli Savolainen added a comment - With hebrew, a separator seems to show even under the active first-level tab, see: http://moodle.org/mod/forum/discuss.php?d=111241#p488246

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10