Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.10, 2.2.11, 2.3.11
    • Component/s: Feedback
    • Labels:
      None
    • Testing Instructions:
      Hide

      Most string hasn't to be tested except numeric item (maximum, minimum)

      1. create a feedback instance
      2. create two numeric questions
        the first one with Range from: 10 and Range to "-"
        the second one with Range from: "-" and Range to 10
      3. look at the preview
      4. do a submit and look there
      Show
      Most string hasn't to be tested except numeric item (maximum, minimum) create a feedback instance create two numeric questions the first one with Range from: 10 and Range to "-" the second one with Range from: "-" and Range to 10 look at the preview do a submit and look there
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-14507_master_wip
    • Rank:
      540

      Description

      Moodle code should always use "Headings like this" instead of "Headings Like This".

        Activity

        Martin Dougiamas created issue -
        Martin Dougiamas made changes -
        Field Original Value New Value
        Assignee Anthony Borrow [ aborrow ] Andreas Grabs [ grabs ]
        Hide
        Anthony Borrow added a comment -

        Andreas - I went ahead and fixed some of the words with uppercase in the en_utf8 language file since I may have actually introduced some of that bad form. Let me know if there are other files you would like for me to look at so that you can better focus on Martin's inquiry about using the Moodle question types. I also removed some of double quotes that were used for some strings. Peace - Anthony

        Show
        Anthony Borrow added a comment - Andreas - I went ahead and fixed some of the words with uppercase in the en_utf8 language file since I may have actually introduced some of that bad form. Let me know if there are other files you would like for me to look at so that you can better focus on Martin's inquiry about using the Moodle question types. I also removed some of double quotes that were used for some strings. Peace - Anthony
        Anthony Borrow made changes -
        Fix Version/s 1.9.1 [ 10262 ]
        Fix Version/s 1.9 [ 10200 ]
        Martin Dougiamas made changes -
        Project Non-core contributed modules [ 10033 ] Moodle [ 10011 ]
        Key CONTRIB-77 MDL-14507
        Component/s Feedback [ 10302 ]
        Component/s Module: Feedback [ 10204 ]
        Fix Version/s 2.0 [ 10122 ]
        Fix Version/s 1.9.1 [ 10262 ]
        Affects Version/s 2.0 [ 10122 ]
        Affects Version/s 1.9 [ 10200 ]
        Martin Dougiamas made changes -
        Fix Version/s 2.0.1 [ 10420 ]
        Fix Version/s 2.0 [ 10122 ]
        Martin Dougiamas made changes -
        Workflow jira [ 22191 ] MDL Workflow [ 42494 ]
        Martin Dougiamas made changes -
        Fix Version/s 2.0.2 [ 10421 ]
        Fix Version/s 2.0.1 [ 10420 ]
        Martin Dougiamas made changes -
        Fix Version/s 2.0.3 [ 10537 ]
        Fix Version/s 2.0.2 [ 10421 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 42494 ] MDL Full Workflow [ 70913 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.4 [ 10652 ]
        Fix Version/s 2.0.3 [ 10537 ]
        Martin Dougiamas made changes -
        Fix Version/s 2.0.5 [ 10950 ]
        Fix Version/s 2.0.4 [ 10652 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.6 [ 11250 ]
        Fix Version/s 2.0.5 [ 10950 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.7 [ 11451 ]
        Fix Version/s 2.0.6 [ 11250 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.8 [ 11554 ]
        Fix Version/s 2.0.7 [ 11451 ]
        Hide
        Andreas Grabs added a comment -

        I would say this is solved already just with other issues and not explicit mentioned here.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - I would say this is solved already just with other issues and not explicit mentioned here. Best regards Andreas
        Andreas Grabs made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Anthony Borrow added a comment -

        Andreas - Looking at the current mod/feedback/lang/en/feedback.php, I notice some of the strings do not begin with a capital letter. I'm not sure if you want to clean up any of these or not as I believe sometimes it may be appropriate to begin with lowercase but I figured I would list them for your convenience:

        $string['cannotsavetempl'] = 'saving templates is not allowed';
        $string['completed'] = 'completed';
        $string['dependitem'] = 'depend item';
        $string['dependvalue'] = 'depend value';
        $string['emailnotification'] = 'emailnotifications'; *missing space probably should be corrected to "Email notifications"

        $string['feedback_is_not_for_anonymous'] = 'feedback is not for anonymous'; *I'm not sure what this really means. I might suggest "This feedback is not setup for anonymous responses" or "This feedback is not configured to be completed by anonymous users"

        $string['maximal'] = 'maximal'; *You may want to check if this should be maximum and minimum, maximal and minimal seems awkward to me. I am familiar with minimal but it is typically used in a different context.

        $string['send'] = 'send';
        $string['send_message'] = 'send message';
        string['started'] = 'started';
        $string['switch_item_to_not_required'] = 'switch to: answer not required';
        $string['switch_item_to_required'] = 'switch to: answer required';
        $string['typemissing'] = 'missing value "type"';
        $string['vertical'] = 'vertical';
        $string['viewcompleted'] = 'completed feedbacks';

        Peace - Anthony

        p.s. - You may want to ask Helen Foster to give the file a look or another native English speaker just to clean it up a bit.

        Show
        Anthony Borrow added a comment - Andreas - Looking at the current mod/feedback/lang/en/feedback.php, I notice some of the strings do not begin with a capital letter. I'm not sure if you want to clean up any of these or not as I believe sometimes it may be appropriate to begin with lowercase but I figured I would list them for your convenience: $string ['cannotsavetempl'] = 'saving templates is not allowed'; $string ['completed'] = 'completed'; $string ['dependitem'] = 'depend item'; $string ['dependvalue'] = 'depend value'; $string ['emailnotification'] = 'emailnotifications'; *missing space probably should be corrected to "Email notifications" $string ['feedback_is_not_for_anonymous'] = 'feedback is not for anonymous'; *I'm not sure what this really means. I might suggest "This feedback is not setup for anonymous responses" or "This feedback is not configured to be completed by anonymous users" $string ['maximal'] = 'maximal'; *You may want to check if this should be maximum and minimum, maximal and minimal seems awkward to me. I am familiar with minimal but it is typically used in a different context. $string ['send'] = 'send'; $string ['send_message'] = 'send message'; string ['started'] = 'started'; $string ['switch_item_to_not_required'] = 'switch to: answer not required'; $string ['switch_item_to_required'] = 'switch to: answer required'; $string ['typemissing'] = 'missing value "type"'; $string ['vertical'] = 'vertical'; $string ['viewcompleted'] = 'completed feedbacks'; Peace - Anthony p.s. - You may want to ask Helen Foster to give the file a look or another native English speaker just to clean it up a bit.
        Hide
        Andreas Grabs added a comment -

        Anthony thank you very much. I fix this directly.
        Andreas

        Show
        Andreas Grabs added a comment - Anthony thank you very much. I fix this directly. Andreas
        Andreas Grabs made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Fix Version/s 2.2.2 [ 11552 ]
        Fix Version/s 2.3 [ 10657 ]
        Andreas Grabs made changes -
        Status Reopened [ 4 ] Waiting for integration review [ 10010 ]
        Pull Master Diff URL https://github.com/grabs/moodle/compare/master...MDL-14507_master_wip
        Pull Master Branch MDL-14507_master_wip
        Pull 2.0 Diff URL https://github.com/grabs/moodle/compare/MOODLE_20_STABLE...MDL-14507_20_wip
        Pull from Repository git://github.com/grabs/moodle.git
        Pull 2.0 Branch MDL-14507_20_wip
        Testing Instructions Most string hasn't to be tested except numeric item (maximum, minimum)
        # create a feedback instance
        # create two numeric questions
        the first one with Range from: 10 and Range to "-"
        the second one with Range from: "-" and Range to 10
        # look at the preview
        # do a submit and look there
        Pull 2.1 Branch MDL-14507_21_wip
        Pull 2.2 Diff URL https://github.com/grabs/moodle/compare/MOODLE_22_STABLE...MDL-14507_22_wip
        Pull 2.1 Diff URL https://github.com/grabs/moodle/compare/MOODLE_21_STABLE...MDL-14507_21_wip
        Pull 2.2 Branch MDL-14507_22_wip
        Sam Hemelryk made changes -
        Currently in integration Yes [ 10041 ]
        Sam Hemelryk made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Integrator samhemelryk
        Hide
        Sam Hemelryk added a comment - - edited

        Hi Andreas,

        I've just been looking at this now.
        The changes look good thanks, however a couple of things need to be fixed up before this gets in to core.

        1/ We don't remove or rename strings in the stable branches. For the 20, 21, and 22 branches you'll need to leave the maximal string in there and just add maximum as a new string.

        2/ In the master branch renaming is fine however when renaming a string identifier you need to include some AMOS syntax so that AMOS knows that you are renaming a string, rather than removing one and adding another. By doing this AMOS will copy the existing translations as well as marking the word as changed.
        You can find information about that here: http://docs.moodle.org/dev/Languages/AMOS

        Other than that things look spot on thanks, yell out if you have any questions.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - - edited Hi Andreas, I've just been looking at this now. The changes look good thanks, however a couple of things need to be fixed up before this gets in to core. 1/ We don't remove or rename strings in the stable branches. For the 20, 21, and 22 branches you'll need to leave the maximal string in there and just add maximum as a new string. 2/ In the master branch renaming is fine however when renaming a string identifier you need to include some AMOS syntax so that AMOS knows that you are renaming a string, rather than removing one and adding another. By doing this AMOS will copy the existing translations as well as marking the word as changed. You can find information about that here: http://docs.moodle.org/dev/Languages/AMOS Other than that things look spot on thanks, yell out if you have any questions. Cheers Sam
        Sam Hemelryk made changes -
        Status Integration review in progress [ 10004 ] Reopened [ 4 ]
        Hide
        Sam Hemelryk added a comment -

        Actually just discussing this with Eloy I realised that the stable branches should include AMOS syntax as well.
        In the master branch it will be a MOV (as you are renaming).
        In the stable branches you should use CPY.
        Maximum and maximal are very similar, maximal is a technical, where as maximum is more common (and certainly more correct in regards to the context in which it is used) however maximal is still valid and coping it at least ensures currently translations are not lost.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Actually just discussing this with Eloy I realised that the stable branches should include AMOS syntax as well. In the master branch it will be a MOV (as you are renaming). In the stable branches you should use CPY. Maximum and maximal are very similar, maximal is a technical, where as maximum is more common (and certainly more correct in regards to the context in which it is used) however maximal is still valid and coping it at least ensures currently translations are not lost. Cheers Sam
        Hide
        Andreas Grabs added a comment -

        Hi Sam,
        thank you for this info! I did knowing this .
        That means in 20,21,22 I only add the new string-identifier "minimum" and change only the text of "maximal"
        and
        in master I can change the identifier "maximal" to "maximum" and adding the new identifier "maximal"
        am I right?
        I do not fully understand, where I can include the AMOS syntax. In the documentation I did not found or understand this .
        Andreas

        Show
        Andreas Grabs added a comment - Hi Sam, thank you for this info! I did knowing this . That means in 20,21,22 I only add the new string-identifier "minimum" and change only the text of "maximal" and in master I can change the identifier "maximal" to "maximum" and adding the new identifier "maximal" am I right? I do not fully understand, where I can include the AMOS syntax. In the documentation I did not found or understand this . Andreas
        Eloy Lafuente (stronk7) made changes -
        Currently in integration Yes [ 10041 ]
        Hide
        Andreas Grabs added a comment -

        Hi,
        I have corrected just the 20,21 and 22 branches.
        I hope it is ok so.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - Hi, I have corrected just the 20,21 and 22 branches. I hope it is ok so. Best regards Andreas
        Hide
        Anthony Borrow added a comment -

        Andreas - At this point only security fixes are being made to 1.9 so 2.x fixes should be just fine. Peace - Anthony

        Show
        Anthony Borrow added a comment - Andreas - At this point only security fixes are being made to 1.9 so 2.x fixes should be just fine. Peace - Anthony
        Hide
        Andreas Grabs added a comment -

        Hi Anthony,
        the problem was the adding of new lang identifiers into stable branches. Now I modified my changes. In the stable branches the old lang identifiers are not vanished any more.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - Hi Anthony, the problem was the adding of new lang identifiers into stable branches. Now I modified my changes. In the stable branches the old lang identifiers are not vanished any more. Best regards Andreas
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.9 [ 12051 ]
        Fix Version/s 2.0.8 [ 11554 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.3 [ 12053 ]
        Fix Version/s 2.2.2 [ 11552 ]
        Hide
        Andreas Grabs added a comment -

        Hi,
        I would like to know whether there are some things I can/have to do so that these commits will be integrated.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - Hi, I would like to know whether there are some things I can/have to do so that these commits will be integrated. Best regards Andreas
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.0.10 [ 12160 ]
        Fix Version/s 2.0.9 [ 12051 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.4 [ 12162 ]
        Fix Version/s 2.2.3 [ 12053 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.1 [ 12253 ]
        Fix Version/s 2.3 [ 10657 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.5 [ 12352 ]
        Fix Version/s 2.2.4 [ 12162 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.2 [ 12353 ]
        Fix Version/s 2.3.1 [ 12253 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.6 [ 12372 ]
        Fix Version/s 2.2.5 [ 12352 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.3 [ 12373 ]
        Fix Version/s 2.3.2 [ 12353 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.7 [ 12456 ]
        Fix Version/s 2.2.6 [ 12372 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.4 [ 12457 ]
        Fix Version/s 2.3.3 [ 12373 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.8 [ 12557 ]
        Fix Version/s 2.2.7 [ 12456 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.5 [ 12558 ]
        Fix Version/s 2.3.4 [ 12457 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.9 [ 12567 ]
        Fix Version/s 2.2.8 [ 12557 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.6 [ 12568 ]
        Fix Version/s 2.3.5 [ 12558 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.7 [ 12574 ]
        Fix Version/s 2.3.6 [ 12568 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.10 [ 12573 ]
        Fix Version/s 2.2.9 [ 12567 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.2.11 [ 12655 ]
        Fix Version/s 2.2.10 [ 12573 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.8 [ 12654 ]
        Fix Version/s 2.3.7 [ 12574 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.9 [ 12662 ]
        Fix Version/s 2.3.8 [ 12654 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.10 [ 12752 ]
        Fix Version/s 2.3.9 [ 12662 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 2.3.11 [ 12853 ]
        Fix Version/s 2.3.10 [ 12752 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: