Moodle
  1. Moodle
  2. MDL-14531

Replace in lists '1.)' either by '1.' or '1)'

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Feedback
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35006

      Description

      Feedback questions are numbered as:

      1.) first
      2.) second
      3.) third
      ...

      I suggest to replace it by

      1. first
      2. second
      3. third
      ...

      That is, leave only a dot after the numbers. This is a typical style for numbered lists in browsers.

      The patching may be performed by the command:

      grep -l '\.)' *|while read f; do sed 's/\.)/./g' $f >%D/$f;done

      (new files were created in the opposite panel directory in Midnight Commander).

      The files affected:

      complete_guest.php
      complete.php
      edit.php
      print.php
      show_entries_anonym.php
      show_entries.php
      use_templ.php

        Activity

        Hide
        David Mudrak added a comment -

        I propose to introduce new module $string['numberingformat'] using integer $a as a parameter. This will be used to display numbering. Then we can have 1) 1. #1 etc. according to language typical usage.

        Show
        David Mudrak added a comment - I propose to introduce new module $string ['numberingformat'] using integer $a as a parameter. This will be used to display numbering. Then we can have 1) 1. #1 etc. according to language typical usage.
        Hide
        Andreas Grabs added a comment -

        I dont think it is a good idea. In my opinion the better way is to offer an option in the edit-page of feedback that looks like the option "Number the choices?" in the multiplechoice question from quiz-module.

        Show
        Andreas Grabs added a comment - I dont think it is a good idea. In my opinion the better way is to offer an option in the edit-page of feedback that looks like the option "Number the choices?" in the multiplechoice question from quiz-module.
        Hide
        David Mudrak added a comment -

        Andreas, we are talking about two different issues:
        1) whether to number questions
        2) if so, what the numbering format should be.

        Please note, e.g. in English speaking countries, format #1, #2, #3 etc is quite often, while this may be something strange in othe languages (like Czech). Therefore, the numbering format should go into lang pack. Of course, you can still add an option, whether to display question numbers.

        p.s. there are more affected files item/*/lib.php - Igor forgot recursive grep.

        Show
        David Mudrak added a comment - Andreas, we are talking about two different issues: 1) whether to number questions 2) if so, what the numbering format should be. Please note, e.g. in English speaking countries, format #1, #2, #3 etc is quite often, while this may be something strange in othe languages (like Czech). Therefore, the numbering format should go into lang pack. Of course, you can still add an option, whether to display question numbers. p.s. there are more affected files item/*/lib.php - Igor forgot recursive grep.
        Hide
        David Mudrak added a comment -

        I have reassigned this to myself, because I need to have this fixed tonight Andreas, please let me know your final decision if I can commit the patch or not.

        Show
        David Mudrak added a comment - I have reassigned this to myself, because I need to have this fixed tonight Andreas, please let me know your final decision if I can commit the patch or not.
        Hide
        David Mudrak added a comment -

        Any comments on this? If not, I will consider the proposal approved

        Show
        David Mudrak added a comment - Any comments on this? If not, I will consider the proposal approved
        Hide
        Andreas Grabs added a comment -

        Now the numbering will be shown as "x." eg: 1.
        On module settings you can switch the autonumbering on or off.

        Show
        Andreas Grabs added a comment - Now the numbering will be shown as "x." eg: 1. On module settings you can switch the autonumbering on or off.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: