-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.8.5
-
Component/s: Feedback
-
Labels:None
-
Environment:Spotted at MOODLE_18_STABLE checked out from CONTRIB
-
Database:PostgreSQL
-
Affected Branches:MOODLE_18_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
PostgreSQL does not like queries with
... WHERE id = ''
The following code in mod_form.php (around line# 61) throws error:
if ($feedback = get_record("feedback", "id", $this->_instance)) {
$completedFeedbackCount = feedback_get_completeds_group_count($feedback);
} else {
$completedFeedbackCount = false;
}
My proposal is to use:
if (is_numeric($this->_instance) && ($feedback = get_record("feedback", "id", $this->_instance))) {
$completedFeedbackCount = feedback_get_completeds_group_count($feedback);
} else {
$completedFeedbackCount = false;
}