Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14736

issue deleting temp dirs in backup

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.8.3, 1.9
    • 1.9.5, 2.0
    • Backup
    • None
    • MOODLE_18_STABLE, MOODLE_19_STABLE
    • MOODLE_19_STABLE, MOODLE_20_STABLE

    Description

      Hi Eloy,

      this is related to the user post here:
      http://moodle.org/mod/forum/discuss.php?d=95768#p426822

      it seems to happen in backup_execute() in backuplib.php

      obviously for some reason, backup_delete_old_data() is failing and not deleting the directories inside directories completely - I haven't looked closely - but is this a bug in backup_delete_old_dirs() ? - the user is using an older version of moodle so it's potentially fixed.....

      I suggest we change the call in backup_execute:
      if (!defined('BACKUP_SILENTLY'))

      { error ("An error occurred deleting old backup data"); }

      ... to use a debugging call instead of the error() function.. - the fact that it hasn't deleted all the old dirs in temp doesn't actually affect the backup itself, which should succeed fine, and simply displaying a warning should suffice IMO

      thanks,

      Dan

      Attachments

        Activity

          People

            danmarsden Dan Marsden
            danmarsden Dan Marsden
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/May/09