Patch for Moodle 1.9.4+ added

Assigned to Eloy because by default this was assign to Nobody.

Adding some people here...

I think it's a good idea to offer that "switch to/from English" feature in help files.

Just thinking if that should be showed only to admins or, at least, be enable/disable it by some $CFG setting... any comment will be welcome.

Thanks for the idea and patch, Dmitry!

My +0x00000001 to have this in both the STABLE and HEAD.

IMO there is no additional setting needed to allow this because:

1) remember the Basic Rule of Help Files - they don't read it
2) all users should be able to easily get actual and full help - not just admins, teachers or some privileged roles
3) this does not influence UI too much so I do not expect objections

I am going to test and patch tomorrow so it can be reviewed and QA'ed during the tuesday

Thanks for the patch, Dmitry!

+1 for visibility of link to all

I have slightly modified the Dmitry's patch:

• now it displays "Show this help in language: English" text link instead of the plain shortcut "en" (replaces English with the corresponding current language name if offering a backward link) - this needs new string in moodle.php
• it does not offer a link to the English help file if such one is already displayed due to "fallback to English" feature

This is the patch I am going to use against the MOODLE_19_STABLE

Fixed in MOODLE_19_STABLE and merged into HEAD

Hi David,

just looking your patch... what happens if the currentlang help file doesn't exist and moodle defaults to the en_utf8 one? Will the link to the (un-existing) currentlang file be showed? Reading help.php it seems that it always set $helpfound to true, no matter if it's the currentlang or the fallback (en_utf8). Just one case for testing...ciao

> Will the link to the (un-existing) currentlang file be showed?
no

$helpfound is checked just for cases when the help file does not exists even in the English pack

Tested and working ok. Closing. Thanks David! B-)