Moodle
  1. Moodle
  2. MDL-14745

emails not match message on singup page.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      2056

      Description

      When a potential user types in different emails on Moodle signup page (login/signup_form.php),
      an error message $string['invalidemail'] = 'Invalid email address'; is shown to the user.
      I think that this is a bit confusing error message for potential users.

      So, for better instruction, I'd suggest putting another error message and fix login/signup_form.php as below.

      Index: lang/en_utf8/moodle.php
      ===================================================================
      RCS file: /cvsroot/moodle/moodle/lang/en_utf8/moodle.php,v
      retrieving revision 1.180
      diff -u -r1.180 moodle.php
      — lang/en_utf8/moodle.php 20 Apr 2008 01:18:44 -0000 1.180
      +++ lang/en_utf8/moodle.php 8 May 2008 07:14:17 -0000
      @@ -480,6 +480,7 @@
      $string['emailmustbereal'] = 'Note: your email address must be a real one';
      $string['emailnotallowed'] = 'Email addresses in these domains are not allowed ($a)';
      $string['emailnotfound'] = 'The email address was not found in the database';
      +$string['emailnotmatch'] = 'Your emails do not match!';
      $string['emailonlyallowed'] = 'This email is not one of those that are allowed ($a)';
      $string['emailpasswordconfirmation'] = 'Hi $a->firstname,

      Index: login/signup_form.php
      ===================================================================
      RCS file: /cvsroot/moodle/moodle/login/signup_form.php,v
      retrieving revision 1.40
      diff -u -r1.40 signup_form.php
      — login/signup_form.php 31 Mar 2008 12:13:46 -0000 1.40
      +++ login/signup_form.php 8 May 2008 07:15:14 -0000
      @@ -123,7 +123,7 @@
      $errors['email2'] = get_string('missingemail');

      } else if ($data['email2'] != $data['email'])

      { - $errors['email2'] = get_string('invalidemail'); + $errors['email2'] = get_string('emailnotmatch'); }

      if (!isset($errors['email'])) {
      if ($err = email_is_not_allowed($data['email'])) {

      1. moodle.patch
        1 kB
        Mitsuhiro Yoshida

        Activity

        There are no comments yet on this issue.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: