Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14793

MNET curl operations do not check HTTP return code.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0
    • Fix Version/s: 1.9.8, 2.0
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      There is no checking of the return code when curl is used. Curl will happily complete with no PHP error even if there is an HTTP error code returned. A specific check should be made to ensure that 200 is returned, or issue an error. This would make debugging MNET problems a whole lot easier.

        Attachments

          Activity

            People

            • Assignee:
              howardsmiller Howard Miller
              Reporter:
              howardsmiller Howard Miller
              Participants:
              Component watchers:
              Amaia Anabitarte, David Mudrák (@mudrd8mz), Sara Arjona (@sarjona)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Mar/10