Moodle
  1. Moodle
  2. MDL-14858

Description of advanced upload assignment is shown in calendar despite "Hide description before available date"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5
    • Fix Version/s: None
    • Component/s: Assignment (2.2), Calendar
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Rank:
      2066

      Description

      When an "advanced upload" is configured with "Hide description before available date", students can't see the complete information in the "assignment"

      But they can see all the description (and the optionnal attached files) by the calendar, looking at the day of opening

      Steps to reproduce :
      1 : As a teacher, create an advanced upload file assignment
      2 : choose the option "Hide description before available date", and put a "reserved" description
      3 : login as student
      4 : open the calendar, and go to the day "Available from" of the assignment
      5 : you CAN see the "reserved" description, but you shouldn't

      This is a big functionnal bug, because teacher think they can put instructions students won't see, but students can see it...

      This bugs isn't in 1.9.1

        Activity

        Séverin Terrier created issue -
        Hide
        Séverin Terrier added a comment - - edited

        Don't know if it can help, but in 1.9, the lines taking care about that are in moodle/calendar/lib.php near
        // TODO: rewrite this hack somehow
        and
        if ($assignmentinstance->description_is_hidden()){//force not to show description before availability
        $event->description = get_string('notavailableyet', 'assignment');

        Show
        Séverin Terrier added a comment - - edited Don't know if it can help, but in 1.9, the lines taking care about that are in moodle/calendar/lib.php near // TODO: rewrite this hack somehow and if ($assignmentinstance->description_is_hidden()){//force not to show description before availability $event->description = get_string('notavailableyet', 'assignment');
        Hide
        Valery Fremaux added a comment -

        Severin, I didn't find that lines in 1.9.

        What is certain, is that calendar SHOULD NEVER REFER to assignement or any explicit module semantics. This a breakover on modularity and uncoupling.

        I suggest the best solution should be :

        When generating events in assessment, to twick the description there, and store a shadowed description in event table.

        The cron function for assessments shoud then scan for opening assessments, point again the calendar related events and restablish correct description.

        This is a first solution not using the event framework.

        There should be some using it, but I'm not sure there is a great movement for developping event approach. I would have liked to have MartinD actual position on the question...

        I think I can work about 15 minutes on the patch (without events).

        Show
        Valery Fremaux added a comment - Severin, I didn't find that lines in 1.9. What is certain, is that calendar SHOULD NEVER REFER to assignement or any explicit module semantics. This a breakover on modularity and uncoupling. I suggest the best solution should be : When generating events in assessment, to twick the description there, and store a shadowed description in event table. The cron function for assessments shoud then scan for opening assessments, point again the calendar related events and restablish correct description. This is a first solution not using the event framework. There should be some using it, but I'm not sure there is a great movement for developping event approach. I would have liked to have MartinD actual position on the question... I think I can work about 15 minutes on the patch (without events).
        Hide
        Séverin Terrier added a comment -

        These lines are in 1.9.1...

        Show
        Séverin Terrier added a comment - These lines are in 1.9.1...
        Séverin Terrier made changes -
        Field Original Value New Value
        Affects Version/s 1.8.4 [ 10242 ]
        Affects Version/s 1.8.3 [ 10230 ]
        Affects Version/s 1.8.2 [ 10220 ]
        Affects Version/s 1.8.1 [ 10213 ]
        Affects Version/s 1.8 [ 10130 ]
        Hide
        Petr Škoda added a comment -

        I agree this is definitely not a nice hack, unfortunately it relies on other code from 1.9.x, backport is not trivial.

        Anybody wants to work on this?

        Show
        Petr Škoda added a comment - I agree this is definitely not a nice hack, unfortunately it relies on other code from 1.9.x, backport is not trivial. Anybody wants to work on this?
        Petr Škoda made changes -
        Assignee Petr Skoda [ skodak ] Nobody [ nobody ]
        Priority Critical [ 2 ] Major [ 3 ]
        Petr Škoda made changes -
        Fix Version/s 1.8.7 [ 10291 ]
        Fix Version/s 1.8.6 [ 10270 ]
        Hide
        Susan Mangan added a comment -

        Is there some code I can manually plug into a php file for this bug? We are still using 1.8 and have instructors posting exams (don't ask....) in the Description field of the Advanced Upload of Files Assignment Activity. I thought we would upgrade to 1.9 this Fall so I wouldn't have to worry about this particular issue, but we have not upgraded.. sadly. (don' ask....)

        Thanks in advance!!!

        Show
        Susan Mangan added a comment - Is there some code I can manually plug into a php file for this bug? We are still using 1.8 and have instructors posting exams (don't ask....) in the Description field of the Advanced Upload of Files Assignment Activity. I thought we would upgrade to 1.9 this Fall so I wouldn't have to worry about this particular issue, but we have not upgraded.. sadly. (don' ask....) Thanks in advance!!!
        Martin Dougiamas made changes -
        Fix Version/s 1.8.8 [ 10314 ]
        Fix Version/s 1.8.7 [ 10291 ]
        Petr Škoda made changes -
        Fix Version/s 1.8.9 [ 10322 ]
        Fix Version/s 1.8.8 [ 10314 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.8.10 [ 10350 ]
        Fix Version/s 1.8.9 [ 10322 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.8.11 [ 10383 ]
        Fix Version/s 1.8.10 [ 10350 ]
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s 1.8.12 [ 10401 ]
        Fix Version/s 1.8.11 [ 10383 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.8.13 [ 10406 ]
        Fix Version/s 1.8.12 [ 10401 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.8.14 [ 10411 ]
        Fix Version/s 1.8.13 [ 10406 ]
        Hide
        Petr Škoda added a comment -

        we are very close to release, moving the target, sorry...

        Show
        Petr Škoda added a comment - we are very close to release, moving the target, sorry...
        Petr Škoda made changes -
        Fix Version/s 1.8.15 [ 10440 ]
        Fix Version/s 1.8.14 [ 10411 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.8.15 [ 10440 ]
        Martin Dougiamas made changes -
        Workflow jira [ 26471 ] MDL Workflow [ 43402 ]
        Hide
        Tomasz Muras added a comment -

        This is working fine with latest Moodle 2: 2.0.1+ (Build: 20101229).

        Show
        Tomasz Muras added a comment - This is working fine with latest Moodle 2: 2.0.1+ (Build: 20101229).
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 43402 ] MDL Full Workflow [ 71798 ]
        Hide
        Dan Marsden added a comment -

        closing as won't fix - this is working in 1.9 and 2.0 stable branches and no-one is maintaining 1.8 anymore.

        If you're still having trouble with this, please upgrade to the latest 1.9stable or 2.0stable release

        Show
        Dan Marsden added a comment - closing as won't fix - this is working in 1.9 and 2.0 stable branches and no-one is maintaining 1.8 anymore. If you're still having trouble with this, please upgrade to the latest 1.9stable or 2.0stable release
        Dan Marsden made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Nobody [ nobody ] Dan Marsden [ danmarsden ]
        Resolution Won't Fix [ 2 ]

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: