Moodle
  1. Moodle
  2. MDL-14883

Password expiration check during login doesn't work after NTLM integration.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      As part of the NTLM integration work, we moved some login code from login/index.php to lib/moodlelib.php (function complete_user_login()). This broke the password expiration check code, as we moved the $userauth variable to complete_user_login(), and we also need it in login/index.php later.

      The attached patch fixes the issue, and removes the now inexistant $focus variable from the call to print_header().

      I've tested the patch locally with Active Directory (as the original report talked about AD password expiry support - see -http://moodle.org/mod/forum/discuss.php?d=97060 -) and it works as expected. If nobody opposes to it, i'll check it into CVS in a day or so.

      Saludos. Iñaki.

        Gliffy Diagrams

          Activity

          Hide
          Iñaki Arenaza added a comment -

          Patch committed into CVS, both in MOODLE_19_STABLE and HEAD. Marking the bug as resolved so it can be assigned a QA person.

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Patch committed into CVS, both in MOODLE_19_STABLE and HEAD. Marking the bug as resolved so it can be assigned a QA person. Saludos. Iñaki.
          Hide
          Petr Skoda added a comment -

          thanks

          Show
          Petr Skoda added a comment - thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: