Moodle
  1. Moodle
  2. MDL-18083 META: Gradebook improvements - Stage 1
  3. MDL-14961

Adding a help button next to the "Synchronise legacy grades" in gradebook 1.9

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9.5
    • Component/s: Gradebook, Usability
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      The new gradebook in Moodle 1.9 has some usability issues. For one, when you go to the gradebook, and use the drop-down menu on the upper-left corner (Choose an action) and select Edit => Categories and Items, it would show you this screen (see attached screenshot). There are three buttons on the bottom, but the "Synchronise legacy grades" is a bit confusing and I think we could add an extra help button right next to it to explain what it would do, what do people think?

      Just my $0.02...

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Helen Foster added a comment -

            Wen, thanks for your suggestion for improving usability.

            Show
            Helen Foster added a comment - Wen, thanks for your suggestion for improving usability.
            Hide
            Nicolas Connault added a comment -

            Legacy grades are the grades that used to be stored in module tables before 1.9. Normally these grades are migrated to the new gradebook tables during the 1.9 upgrade. However there are some situations when some old grades are not yet in the gradebook. This button checks for these unmoved grades and completes the synchronisation.

            Show
            Nicolas Connault added a comment - Legacy grades are the grades that used to be stored in module tables before 1.9. Normally these grades are migrated to the new gradebook tables during the 1.9 upgrade. However there are some situations when some old grades are not yet in the gradebook. This button checks for these unmoved grades and completes the synchronisation.
            Hide
            Helen Foster added a comment -

            Nicolas, thanks for explaining things.

            Is it possible for the 'Synchronise legacy grades' button to not appear for new Moodle 1.9 installs and to disappear once synchronisation is complete?

            Show
            Helen Foster added a comment - Nicolas, thanks for explaining things. Is it possible for the 'Synchronise legacy grades' button to not appear for new Moodle 1.9 installs and to disappear once synchronisation is complete?
            Hide
            Helen Foster added a comment -

            Suggested synchronise legacy grades help file wording:

            Synchronise legacy grades

            The term 'legacy grades' refers to grades from versions of Moodle prior to 1.9. When upgrading, all legacy grades should be included in the Moodle 1.9 gradebook. The 'Synchronise legacy grades' button checks whether this is the case, and if necessary adds any missing legacy grades to the Moodle 1.9 gradebook.

            Show
            Helen Foster added a comment - Suggested synchronise legacy grades help file wording: Synchronise legacy grades The term 'legacy grades' refers to grades from versions of Moodle prior to 1.9. When upgrading, all legacy grades should be included in the Moodle 1.9 gradebook. The 'Synchronise legacy grades' button checks whether this is the case, and if necessary adds any missing legacy grades to the Moodle 1.9 gradebook.
            Hide
            Helen Foster added a comment -

            Nicolas, please could you add a Synchronise legacy grades help popup and investigate whether the 'Synchronise legacy grades' button can be made to not appear for new Moodle 1.9 installs and to disappear once synchronisation is complete?

            Show
            Helen Foster added a comment - Nicolas, please could you add a Synchronise legacy grades help popup and investigate whether the 'Synchronise legacy grades' button can be made to not appear for new Moodle 1.9 installs and to disappear once synchronisation is complete?
            Hide
            Kathy Cannon (Brandeis Univ) added a comment -

            We are upgrading (in place) from 1.8.5 (with Gradebook Plus v2) to 1.9.4. Our instructors/graders do not need to see the Synchronise Legacy Grades button at all. I do not see a place in the site settings or role capabilities to make this function appear only for admins. That would be a helpful addition.

            Show
            Kathy Cannon (Brandeis Univ) added a comment - We are upgrading (in place) from 1.8.5 (with Gradebook Plus v2) to 1.9.4. Our instructors/graders do not need to see the Synchronise Legacy Grades button at all. I do not see a place in the site settings or role capabilities to make this function appear only for admins. That would be a helpful addition.
            Hide
            Nicolas Connault added a comment -

            The help file has been added, and the button implemented in 1.9 and HEAD.

            Show
            Nicolas Connault added a comment - The help file has been added, and the button implemented in 1.9 and HEAD.
            Hide
            Helen Foster added a comment -

            Only displaying the 'Synchronise legacy grades' button when necessary added as a separate issue - MDL-18523

            Show
            Helen Foster added a comment - Only displaying the 'Synchronise legacy grades' button when necessary added as a separate issue - MDL-18523
            Hide
            Helen Foster added a comment -

            Nicolas, thanks for fixing this issue.

            Watchers, thanks for your interest. Please consider watching / voting for / commenting on MDL-18523.

            Show
            Helen Foster added a comment - Nicolas, thanks for fixing this issue. Watchers, thanks for your interest. Please consider watching / voting for / commenting on MDL-18523 .
            Hide
            Petr Skoda added a comment -

            Technically it is not correct, "legacy grades" are grades from activities that do not have new 1.9.x stype "push" gradebook hooks

            Originally the gradebook was pulling the grades from activities when doing gradebook calculations on the fly (each gradebook view),
            now the grades are "pushed" into gradebook when they change and are recalculated only when needed.
            "Legacy grades" is a temporary backwards compatibility hack which pulls old style grades from unmaintained activities, ideally all of them should be upgraded by now, unfortunately that is not the case

            Show
            Petr Skoda added a comment - Technically it is not correct, "legacy grades" are grades from activities that do not have new 1.9.x stype "push" gradebook hooks Originally the gradebook was pulling the grades from activities when doing gradebook calculations on the fly (each gradebook view), now the grades are "pushed" into gradebook when they change and are recalculated only when needed. "Legacy grades" is a temporary backwards compatibility hack which pulls old style grades from unmaintained activities, ideally all of them should be upgraded by now, unfortunately that is not the case
            Hide
            Elena Ivanova added a comment -

            Petr, do you know which activities are those?

            Show
            Elena Ivanova added a comment - Petr, do you know which activities are those?
            Hide
            Petr Skoda added a comment -

            no, I do not remember

            Show
            Petr Skoda added a comment - no, I do not remember
            Hide
            Nicolas Connault added a comment -

            Gradebook patch applied, resolving this issue.

            Show
            Nicolas Connault added a comment - Gradebook patch applied, resolving this issue.
            Hide
            Helen Foster added a comment -

            Removing 2.0 fix version as instructions state 'Do not include the current HEAD version unless it's the only one.'

            Show
            Helen Foster added a comment - Removing 2.0 fix version as instructions state 'Do not include the current HEAD version unless it's the only one.'

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: