Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15053

RTL CSS problems: forum indenting and navigation menu formatting

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      standard/rtl.css file has a line in the wrong place

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            Working perfect now on my Hebrew test site.

            Show
            dougiamas Martin Dougiamas added a comment - Working perfect now on my Hebrew test site.
            Hide
            samulik Samuli Karevaara added a comment -

            I'm reopening this. The bug description (line in wrong place) has been fixed. But the bug itself (RTL CSS problems: forum indenting and navigation menu formatting) still seems to be there. I verified that the new CSS and the fixed line position are in there, but some problems remain, see the attached picture (for Arabic test):

            • The Navigation menu has LTR instead of RTL as far as I can tell?
            • The rounded corners in the forum posts are in the wrong places.
            • The navigation bar has the site name (Keski-Suomen Koulu) and the course short name (FYS-101) in left-to-right order, should they also be in right-to-left?

            I don't know much about how the RTL is supposed to work, so apologies if my conclusions are wrong.

            Martin, if you get different results, can you attach a screenshot? I'm testing 1.9 stable only, with Firefox 2.0.0.14.

            Show
            samulik Samuli Karevaara added a comment - I'm reopening this. The bug description (line in wrong place) has been fixed. But the bug itself (RTL CSS problems: forum indenting and navigation menu formatting) still seems to be there. I verified that the new CSS and the fixed line position are in there, but some problems remain, see the attached picture (for Arabic test): The Navigation menu has LTR instead of RTL as far as I can tell? The rounded corners in the forum posts are in the wrong places. The navigation bar has the site name (Keski-Suomen Koulu) and the course short name (FYS-101) in left-to-right order, should they also be in right-to-left? I don't know much about how the RTL is supposed to work, so apologies if my conclusions are wrong. Martin, if you get different results, can you attach a screenshot? I'm testing 1.9 stable only, with Firefox 2.0.0.14.
            Hide
            dougiamas Martin Dougiamas added a comment -

            Yes, RTL is a wierd thing. I think the browser tries to do something intelligent with mixed RTL and LTR text, because some of the mixing up seems reduced on a fully RTL site.

            Could you please file new bugs for all these and I'll try to find a RTL expert to examine them. I'll close this because the main problems I was seeing are fixed.

            The rounded corners: quick fix is to disable the "styles_moz" file from the current theme ... those rounded corners just don't work properly in RTL. I suppose we could add heaps of overrides into rtl.css to disable them.

            Show
            dougiamas Martin Dougiamas added a comment - Yes, RTL is a wierd thing. I think the browser tries to do something intelligent with mixed RTL and LTR text, because some of the mixing up seems reduced on a fully RTL site. Could you please file new bugs for all these and I'll try to find a RTL expert to examine them. I'll close this because the main problems I was seeing are fixed. The rounded corners: quick fix is to disable the "styles_moz" file from the current theme ... those rounded corners just don't work properly in RTL. I suppose we could add heaps of overrides into rtl.css to disable them.
            Hide
            samulik Samuli Karevaara added a comment -

            Closed as suggested. Three new issues were filed for the remaining oddities, see the linked issues.

            Show
            samulik Samuli Karevaara added a comment - Closed as suggested. Three new issues were filed for the remaining oddities, see the linked issues.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/08