Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15183

changes in lib/graphlib are causing notices in overview graph

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.2
    • Fix Version/s: 1.9.2
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Before changes in the graphlib I had the following lines in the overview graph :

      //following two lines seem to silence notice warnings from graphlib.php
      $line->y_tick_labels = null;
      $line->offset_relation = null;

      Since changes in graphlib these no longer work but now these lines silence the warnings :

      //following two lines seem to silence notice warnings from graphlib.php
      $line->parameter['y_tick_labels'] = null;
      $line->offset_relation = null;

      I think other graphs need to be checked to see if they are also broken. The library really needs fixing so that these properties are set to a sensible default or something and don't need to be set if they are not used.

      Assigning this to Jenny since according to CVS Jenny made the changes to graphlib.

        Attachments

          Activity

            People

            Assignee:
            jenny-gray Jenny Gray
            Reporter:
            jamiesensei Jamie Pratt
            Tester:
            Nicolas Connault
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jul/08