Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15253

private method grade_report::setup_groups() should be public?

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Method setup_groups() in class grade_report has been changed to private in Moodle 2.0 development head when it should be public (or the grader plug-in needs fixing).

      report/grader and some other grade book plug-ins extend the class grade_report and call setup_groups() witch used to be public. This means that grader and other plug-ins will throw a Fatal error: "Fatal error: Call to private method grade_report::setup_groups() from context 'grade_report_grader' in /var/www/localhost/htdocs/moodle/grade/report/grader/lib.php on line 147" when trying to show or deal with groups.

      This can be fixed by making setup_groups public or protected. I am rather sure it should be one of those as no method in grade_report calls setup_groups so making it private means nothing is or can use it.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                nicolasconnault Nicolas Connault
                Reporter:
                dservos Daniel Servos
                Participants:
                Component watchers:
                David Monllaó, Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10