Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15258

Move data_presets_export() function out from common module specific library

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In some of the core module's "lib.php" files, there are functions defined which are only used in rare situations, by one single other .php file of the module in question. This policy fills up all these lib.php's with large unused code, which decreases Moodle's speed in general.

      An example of an affected module is mod/data:
      For instance, "lib.php" contains the definition of the function data_presets_export() which may only be called from "preset.php" - thus I am suggesting to move the function out into that file.

      Please see discussion at
      http://moodle.org/mod/forum/discuss.php?d=99391

        Attachments

          Activity

            People

            • Assignee:
              roal Robert Allerstorfer
              Reporter:
              roal Robert Allerstorfer
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/08