Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15258

Move data_presets_export() function out from common module specific library

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9.1
    • 1.9.2
    • None
    • Any
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

    Description

      In some of the core module's "lib.php" files, there are functions defined which are only used in rare situations, by one single other .php file of the module in question. This policy fills up all these lib.php's with large unused code, which decreases Moodle's speed in general.

      An example of an affected module is mod/data:
      For instance, "lib.php" contains the definition of the function data_presets_export() which may only be called from "preset.php" - thus I am suggesting to move the function out into that file.

      Please see discussion at
      http://moodle.org/mod/forum/discuss.php?d=99391

      Attachments

        Activity

          People

            roal Robert Allerstorfer
            roal Robert Allerstorfer
            Petr Skoda Petr Skoda
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/Jul/08