Moodle
  1. Moodle
  2. MDL-1530

Wiki diffs useless when using HTML editor

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_14_STABLE

      Description

      The HTML editor makes everything into one long line. The Wiki diff works by line. Could the wiki diff be changed so that it recognizes things like </p>, <br/>, </li>, etc. as end of lines?

        Gliffy Diagrams

          Activity

          Hide
          Martin Dougiamas added a comment -

          From Michael Schneider (moodle at oncode.info) Sunday, 6 June 2004, 11:39 PM:

          It is very difficult to display diffs in html. And if the diff is showed with tags, it may confuse more people...

          I have tried to implement a possible solution. What do you think about it ?

          From Gustav Delius (gwd2 at york.ac.uk) Sunday, 6 June 2004, 11:46 PM:

          That is wonderful! I like it. Just perhaps a bit too much space between lines?

          From Michael Schneider (moodle at oncode.info) Monday, 7 June 2004, 02:09 AM:

          >ou are right... I have removed these additional linebreaks...

          From Gustav Delius (gwd2 at york.ac.uk) Monday, 7 June 2004, 02:18 AM:

          Thanks! Have you committed yet? I can't see any difference.

          From Michael Schneider (moodle at oncode.info) Monday, 7 June 2004, 02:55 AM:

          Between commit and download sf.net may need 8 hours ... You can check it in the file wiki/ewiki/plugins/moodle/diff.php

          if line 93 is a check for $wiki->htmlmode, then you have the new version.

          If it does not fix the bug, please post the html of the page and reopen it. I will have a deeper look into the issue.

          From Gustav Delius (gwd2 at york.ac.uk) Monday, 7 June 2004, 03:15 AM:

          Below is the relevant bit from the source file for the diff page. Notice the large number of <p>'s and <br>'s.

          <table align=center width=100% class=generalbox border=0 cellpadding=20 cellspacing=0><tr><td bgcolor=#FFFFFF class=generalboxcontent><div class=wiki diff A-new-page>

          <br><b>-</b><font color=#990000><p>This is the frst line.</p></font><p><br>

          <br><b>+</b><font color=#009900><p /><p>This is the first line.</p></font><p>

          <p>This is the second line separated from the first by a paragraph break.

          From Gustav Delius (gwd2 at york.ac.uk) Wednesday, 9 June 2004, 05:29 AM:

          Thanks.

          Show
          Martin Dougiamas added a comment - From Michael Schneider (moodle at oncode.info) Sunday, 6 June 2004, 11:39 PM: It is very difficult to display diffs in html. And if the diff is showed with tags, it may confuse more people... I have tried to implement a possible solution. What do you think about it ? From Gustav Delius (gwd2 at york.ac.uk) Sunday, 6 June 2004, 11:46 PM: That is wonderful! I like it. Just perhaps a bit too much space between lines? From Michael Schneider (moodle at oncode.info) Monday, 7 June 2004, 02:09 AM: >ou are right... I have removed these additional linebreaks... From Gustav Delius (gwd2 at york.ac.uk) Monday, 7 June 2004, 02:18 AM: Thanks! Have you committed yet? I can't see any difference. From Michael Schneider (moodle at oncode.info) Monday, 7 June 2004, 02:55 AM: Between commit and download sf.net may need 8 hours ... You can check it in the file wiki/ewiki/plugins/moodle/diff.php if line 93 is a check for $wiki->htmlmode, then you have the new version. If it does not fix the bug, please post the html of the page and reopen it. I will have a deeper look into the issue. From Gustav Delius (gwd2 at york.ac.uk) Monday, 7 June 2004, 03:15 AM: Below is the relevant bit from the source file for the diff page. Notice the large number of <p>'s and <br>'s. <table align=center width=100% class=generalbox border=0 cellpadding=20 cellspacing=0><tr><td bgcolor=#FFFFFF class=generalboxcontent><div class=wiki diff A-new-page> <br><b>-</b><font color=#990000><p>This is the frst line.</p></font><p><br> <br><b>+</b><font color=#009900><p /><p>This is the first line.</p></font><p> <p>This is the second line separated from the first by a paragraph break. From Gustav Delius (gwd2 at york.ac.uk) Wednesday, 9 June 2004, 05:29 AM: Thanks.
          Hide
          Michael Blake added a comment -

          assign to a valid user

          Show
          Michael Blake added a comment - assign to a valid user

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: