Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_14_STABLE
    • Rank:
      10281

      Description

      Whereas Moodle only requires PHP >=4.1 the headers_sent($file,$line) function on line 281 in /mod/wiki/ewiki/ewiki.php requires PHP >= 4.3. Before then headers_sent() could have no arguments. Is this really necessary?

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Michael Schneider (moodle at oncode.info) Tuesday, 8 June 2004, 02:27 PM:

        Are you sure ? http://ch.php.net/manual/en/function.headers-sent.php states: (PHP 3>= 3.0.8, PHP 4 , PHP 5) ?

        From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 8 June 2004, 02:39 PM:

        Of course I am sure

        Read a bit down the page where it says: Note: The optional file and line parameters where added in PHP 4.3.0.

        From Michael Schneider (moodle at oncode.info) Tuesday, 8 June 2004, 02:52 PM:

        Ah, Uh. Sorry. I do not want to be rude, it is very cool that you report all those errors. Thanks a lot. I will fix this and upload a better version this evening (Also for html-diff).

        From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 8 June 2004, 02:57 PM:

        Michael, as I said before: many thanks for all your work on this module. The fact that I am posting so many bug reports and feature requests about it is a sign of how useful the module is. Only good things are worth perfecting.

        From Michael Schneider (moodle at oncode.info) Wednesday, 9 June 2004, 04:25 AM:

        Removed Parameters from ewiki.php

        Show
        Martin Dougiamas added a comment - From Michael Schneider (moodle at oncode.info) Tuesday, 8 June 2004, 02:27 PM: Are you sure ? http://ch.php.net/manual/en/function.headers-sent.php states: (PHP 3>= 3.0.8, PHP 4 , PHP 5) ? From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 8 June 2004, 02:39 PM: Of course I am sure Read a bit down the page where it says: Note: The optional file and line parameters where added in PHP 4.3.0. From Michael Schneider (moodle at oncode.info) Tuesday, 8 June 2004, 02:52 PM: Ah, Uh. Sorry. I do not want to be rude, it is very cool that you report all those errors. Thanks a lot. I will fix this and upload a better version this evening (Also for html-diff). From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 8 June 2004, 02:57 PM: Michael, as I said before: many thanks for all your work on this module. The fact that I am posting so many bug reports and feature requests about it is a sign of how useful the module is. Only good things are worth perfecting. From Michael Schneider (moodle at oncode.info) Wednesday, 9 June 2004, 04:25 AM: Removed Parameters from ewiki.php
        Hide
        Michael Blake added a comment -

        assign to a valid user

        Show
        Michael Blake added a comment - assign to a valid user

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: