Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15501

"Add Blocks" block doesn't use standard formatting

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.5, 1.9.1
    • Fix Version/s: 1.8.6, 1.9.2
    • Component/s: Accessibility, Blocks, Themes
    • Labels:
      None
    • Environment:
      Moodle 1.9.1 (Build: 20080515), PHP 5.2.0, MySQL 5.0.27, RHEL 4
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      This is a minor issue, but it created problems in our custom theme.

      Most blocks in Moodle use this XHTML code:

      <div class="header"><div class="title"><h2>Upcoming Events</h2>

      However, the "Blocks" block,which appears when you turn editing on, and which is used to add blocks to a course, does not follow this scheme. Instead, it looks like this:

      <div class="header">Blocks</div>

      This causes problems with themes which are expecting the convention used with other blocks (the H2 tag in the other block was apparently added for accessibility reasons). In order to bring this block into line with the others, I suggest the attached patch, which adds the appropriate div and H2 tags to the header div.

        Attachments

          Activity

            People

            • Assignee:
              dongsheng Dongsheng Cai
              Reporter:
              lafayettenuke Kenneth Newquist
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias, Adrian Greeve, Mihail Geshoski, Peter Dias, Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/08