Moodle
  1. Moodle
  2. MDL-15555

stop using span tag for nolink and lang, use the original custom moodle tags

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9
    • Fix Version/s: None
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      2107

      Description

      The problem is that <span>s can not be nested - both because you can not have divs in spans and also it is later impossible to find the matching </span>

      The reason for those unfortunate <span class="nolink"> and <span class="lang"> was that html editor did not support custom tags, this is not a cane anymore in tinymce of fckeditor.

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Along with this, it would be nice if the filtering system broke up the texts into "linking" and "nolinking" chunks before sending them to the filters, so that the nolink tag always works for all filters.

          I guess to be correct for this we need to do either one of these:

          1) have all filters declare that they are "linking" type filters or not, so that we just apply to these.
          2) change the tag name to "nofilter" and support "nolink" as a undocumented alternative for backward compatibility.

          Show
          Martin Dougiamas added a comment - Along with this, it would be nice if the filtering system broke up the texts into "linking" and "nolinking" chunks before sending them to the filters, so that the nolink tag always works for all filters. I guess to be correct for this we need to do either one of these: 1) have all filters declare that they are "linking" type filters or not, so that we just apply to these. 2) change the tag name to "nofilter" and support "nolink" as a undocumented alternative for backward compatibility.
          Hide
          Martin Dougiamas added a comment -

          Suggested syntax:

          <nofilter except="mediaplugin multilang"> .... </nofilter>

          Show
          Martin Dougiamas added a comment - Suggested syntax: <nofilter except="mediaplugin multilang"> .... </nofilter>
          Hide
          Petr Škoda added a comment -

          Actually David proposed a lot better solution: use <nolinkstart />xxx<nolinkend /> - the reason is html purifier and tinymce can handle both span and div correctly - otehrwise the strict nesting rules are going to keep breaking everything....

          Show
          Petr Škoda added a comment - Actually David proposed a lot better solution: use <nolinkstart />xxx<nolinkend /> - the reason is html purifier and tinymce can handle both span and div correctly - otehrwise the strict nesting rules are going to keep breaking everything....
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          Michael de Raadt added a comment -

          I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          This is being done as part of a bulk annual clean-up of issues.

          If you still believe this is an issue in supported versions, please create a new issue.

          Show
          Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: