Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15564

URLs with _'s are rejected by clean_param(..., PARAM_URL)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Not a bug
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2
    • Component/s: MNet
    • Labels:
      None
    • Environment:
      Linux, Php v4.3.10
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      To reproduce:
      (Turn networking on?)
      Goto Admin->Networking->Peers
      Under "Add a new host", enter clsa_mnet_a.mroomsonline.com
      Moodle (not Mahara)
      Press the "Add host" button

      Error message: "Invalid URL parameter."

      I believe this is being rejected by clean_param in this code (line 82 in admin/mnet/peers.php):
      ---------
      $temp_wwwroot = clean_param($form->wwwroot, PARAM_URL);
      if ($temp_wwwroot !== $form->wwwroot)

      { trigger_error("We now parse the wwwroot with PARAM_URL. Your URL will need to have a valid TLD, etc."); print_error("invalidurl", 'mnet','peers.php'); exit; }

      ------

      (I can connect to the host correctly if I use clsamneta.mroomsonline.com)

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/08