Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15610

mtable entry for \mod\label\db\install.xml should be label not quiz

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2
    • Component/s: Resource
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      lines 26 and 27 of \mod\label\db\install.xml should be changed to refer to the table "label" rather than quiz.

      This entry is to describe the table being affected by the action. I assume that this was a copy/paste error as the quiz table is not affected by the creation or update of a label.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          Yep looks like a copy/paste error from long ago. Well spotted, thanks!

          Show
          dougiamas Martin Dougiamas added a comment - Yep looks like a copy/paste error from long ago. Well spotted, thanks!
          Hide
          dongsheng Dongsheng Cai added a comment -

          Martin, execute_sql is not available in HEAD.

          $sql = "UPDATE

          {log_display}

          SET mtable = 'label' WHERE module = 'label'";
          $result = $DB->execute($sql);

          Show
          dongsheng Dongsheng Cai added a comment - Martin, execute_sql is not available in HEAD. $sql = "UPDATE {log_display} SET mtable = 'label' WHERE module = 'label'"; $result = $DB->execute($sql);
          Hide
          dougiamas Martin Dougiamas added a comment -

          Beautiful, thanks!

          Show
          dougiamas Martin Dougiamas added a comment - Beautiful, thanks!
          Hide
          skodak Petr Skoda added a comment -

          reviewed, thanks

          Show
          skodak Petr Skoda added a comment - reviewed, thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/08