Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15648

Marking forum read always marks all groups

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.2
    • Fix Version/s: 2.0
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Marking forums read uses:

      function forum_tp_mark_forum_read($userid, $forumid, $groupid=false) {

      However where this is called in markpost.php, it never sets $groupid.

      This means that it marks all posts read even if they belong to groups that the current user cannot see.

      Correct behaviour would be:

      • If user clicks 'Mark read' while viewing the 'all groups' view:
        + Same as at present - mark everything read
      • If user clicks 'Mark read' while viewing an individual group:
        + Mark read only posts that are either (a) in that group, or (b) in the special 'all groups' group (-1).

      The consequence of this problem in core moodle is just that the forum read table is slightly bigger than it needs to be. In OU moodle we have a custom 'read by' feature which uses the content of this table so we noticed the problem.

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              quen Sam Marshall
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10