Moodle
  1. Moodle
  2. MDL-15711

Calendar drop down for choosing courses doesn't work properly for admin with calendar_adminseesall set

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
      None
    • Environment:
      Any
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      When calendar_adminseesall is set and administrator logs in and go to the calendar - he should have a dropdown to navigate to any other course.
      This is not working correctly, because of the bug in function calendar_course_filter_selector - it doesn't declare $CFG as a global but it still tries to use that.
      The fix is trivial - in file calendar/view.php :
      — view.php.orig 2008-07-19 00:16:49.000000000 +0100
      +++ view.php 2008-07-19 00:17:02.000000000 +0100
      @@ -602,7 +602,7 @@
      }

      function calendar_course_filter_selector($getvars = '') {

      • global $USER, $SESSION;
        + global $USER, $SESSION, $CFG;

      if (empty($USER->id) or isguest()) {
      return '';

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d;

          4d6f6f646c6521

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; 4d6f6f646c6521
          Hide
          Tomasz Muras added a comment -

          This seems to be fixed in the latest version, let's close it.

          Show
          Tomasz Muras added a comment - This seems to be fixed in the latest version, let's close it.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: